Skip to content

ci: Check downstream compiles#6

Merged
samuelburnham merged 5 commits into
sp1-newfrom
ci-check-downstream-compiles
Jun 20, 2024
Merged

ci: Check downstream compiles#6
samuelburnham merged 5 commits into
sp1-newfrom
ci-check-downstream-compiles

Conversation

@samuelburnham
Copy link
Copy Markdown
Member

@samuelburnham samuelburnham commented Jun 17, 2024

  • Adds a check-downstream-compiles test for Sphinx and zk-light-clients based on an improved reusable workflow
  • Cherry-picks general CI streamlining changes for sp1-new

Note

Merging this PR requires changing the sp1-new branch protection rule, as the names of required checks have changed

@samuelburnham samuelburnham force-pushed the ci-check-downstream-compiles branch 2 times, most recently from 9dadb7c to b935147 Compare June 17, 2024 19:56
@samuelburnham samuelburnham changed the base branch from dev to sp1-new June 17, 2024 19:56
@samuelburnham samuelburnham force-pushed the ci-check-downstream-compiles branch 2 times, most recently from bcf964a to 4249281 Compare June 17, 2024 22:04
samuelburnham and others added 2 commits June 17, 2024 18:19
- Extended continuous integration (CI) triggers to include the "dev" branch.
- Refactored Github workflows to enhance and simplify CI execution.
- Enabled `git` access for private repositories within the CI environment.
- Incorporated doctests in the CI process.
@samuelburnham samuelburnham force-pushed the ci-check-downstream-compiles branch 2 times, most recently from e6039fe to 10b74eb Compare June 17, 2024 22:32
@samuelburnham samuelburnham marked this pull request as ready for review June 17, 2024 22:54
@samuelburnham samuelburnham force-pushed the ci-check-downstream-compiles branch from 10b74eb to 966a528 Compare June 17, 2024 22:56
wwared
wwared previously approved these changes Jun 19, 2024
Copy link
Copy Markdown

@wwared wwared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor question below

Comment thread .github/workflows/ci.yml Outdated
@wwared
Copy link
Copy Markdown

wwared commented Jun 19, 2024

Another thing I thought of @samuelburnham: we might want to make check-downstream-compiles to not be a required check. If there's some update on plonky3 that is a breaking change, but a Sphinx update deals with that, we would have a circular dependency problem: the Sphinx PR would depend on updating the plonky3 branch, but the check-downstream-compiles on this repo would prevent updating the branch until the Sphinx PR was merged because of the breaking change. Does that make sense?

There might be a better way of dealing with this scenario though, but I think a simple one is to make check-downstream-compiles to not be required

wwared
wwared previously approved these changes Jun 19, 2024
@samuelburnham samuelburnham merged commit e05ad7a into sp1-new Jun 20, 2024
@samuelburnham samuelburnham deleted the ci-check-downstream-compiles branch June 20, 2024 00:32
huitseeker added a commit that referenced this pull request Aug 3, 2024
* ci: Check downstream compiles

* ci: Optimize and streamline CI process for testing and formatting (#2)

- Extended continuous integration (CI) triggers to include the "dev" branch.
- Refactored Github workflows to enhance and simplify CI execution.
- Enabled `git` access for private repositories within the CI environment.
- Incorporated doctests in the CI process.

* Fixup

* Address review

* Prep for merge

---------

Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>
huitseeker added a commit that referenced this pull request Aug 11, 2024
* ci: Check downstream compiles

* ci: Optimize and streamline CI process for testing and formatting (#2)

- Extended continuous integration (CI) triggers to include the "dev" branch.
- Refactored Github workflows to enhance and simplify CI execution.
- Enabled `git` access for private repositories within the CI environment.
- Incorporated doctests in the CI process.

* Fixup

* Address review

* Prep for merge

---------

Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>
huitseeker added a commit that referenced this pull request Aug 12, 2024
* ci: Check downstream compiles

* ci: Optimize and streamline CI process for testing and formatting (#2)

- Extended continuous integration (CI) triggers to include the "dev" branch.
- Refactored Github workflows to enhance and simplify CI execution.
- Enabled `git` access for private repositories within the CI environment.
- Incorporated doctests in the CI process.

* Fixup

* Address review

* Prep for merge

---------

Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>
huitseeker added a commit that referenced this pull request Aug 14, 2024
* ci: Check downstream compiles

* ci: Optimize and streamline CI process for testing and formatting (#2)

- Extended continuous integration (CI) triggers to include the "dev" branch.
- Refactored Github workflows to enhance and simplify CI execution.
- Enabled `git` access for private repositories within the CI environment.
- Incorporated doctests in the CI process.

* Fixup

* Address review

* Prep for merge

---------

Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants