Part cFS/workflows#177, Update Workflows with Internal Logic#2
Open
arielswalker wants to merge 9 commits intomainfrom
Open
Part cFS/workflows#177, Update Workflows with Internal Logic#2arielswalker wants to merge 9 commits intomainfrom
arielswalker wants to merge 9 commits intomainfrom
Conversation
Merge remote-tracking branch 'public-github-nasa/main' into techdev-multitarget-bundle
Also updates two new tools submodules to reflect the updated main branch
6844341 to
cdedbb9
Compare
This was referenced Apr 3, 2026
Closed
cdedbb9 to
885c9f6
Compare
2 tasks
7e90f32 to
4b83016
Compare
4b83016 to
7f31ede
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Branch from nasa#874. Tests updating already existing workflows to use internal logic. This does not delete or add new workflows that matches the internal repositories.
Testing performed
build-doc-reusable.yml
build-run-app-reusable.yml
format-check.yml
unit-test-coverage-reusable.yml
actions/cppcheck
actions/setup-app
actions/start-cfs-container, actions/healthchecklogs, actions/stop-cfs-container
app-static-analysis-reusable.yml
cFE
OSAL
CF
Expected behavior changes
Uses new containers as created here: https://github.com/arielswalker/containers/actions/runs/23948566629
Uses new scripts, actions, and internal logic.
System(s) tested on
GitHub Actions
Additional context
Any workflow that builds cFS using the old build commands will fail because of the techdev-multitarget-bundle changes. These workflows include:
These workflows were not updated because they do not exist internally. The next step is to replace/remove these workflows based on what is done internally.
Some workflows are failing due to findings with the code, rather than the workflow itself not using commands correctly.
.gitattributes was create because GitHub downloads the archive of the entire arielswalker/cFS repository to get to the actions/ folders, which includes things such as the symlink. When the runner downloads the archive and extracts it into a temporary staging folder, the extraction process tries to recreate every file and symlink. When it tries to create the simple_defs symlink, it sees that it points to a submodule directory (cfe/...) that wasn't included in the archive. The extraction process fails immediately, crashing the workflow before it even has a chance to look at your action. This error is seen here: https://github.com/arielswalker/cFE/actions/runs/23951653083/attempts/3
These changes will not work until containers are built and published first. PR to do so is found here.
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Walker, MCSG TECH.