Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| def impl(ctx: task_context): | ||
| # buildifier: disable=function-docstring | ||
| def impl(ctx: TaskContext): |
There was a problem hiding this comment.
The new annotation def impl(ctx: TaskContext) evaluates TaskContext when the module is executed, but no such name is imported or defined. Running the file now raises NameError: name 'TaskContext' is not defined before the task can be registered (python bazel-diff.axl fails immediately), so the task cannot be used at all. Restore the original task_context symbol or defer annotation evaluation.
Useful? React with 👍 / 👎.
2 participants
Also add a real test assertion