Skip to content

chore(deps): upgrade Aspect CLI #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexeagle wants to merge 3 commits into from
Closed

chore(deps): upgrade Aspect CLI #1

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c96ccd7
some fixes
alexeagle Nov 13, 2025
2a4e519
GH fetch is broken
alexeagle Nov 14, 2025
a399314
module files
alexeagle Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
uses: jaxxstorm/action-install-gh-release@v2.1.0
with:
repo: aspect-build/aspect-cli
tag: 2025.42.8
tag: v2025.46.20
asset-name: aspect-cli
platform: unknown_linux
arch: x86_64
Expand Down
10 changes: 5 additions & 5 deletions bazel-diff.axl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ https://github.com/Tinder/bazel-diff/blob/master/bazel-diff-example.sh
def exec(command):
return command.stdout("piped").spawn().wait_with_output().stdout.strip()


def impl(ctx: task_context):
# buildifier: disable=function-docstring
def impl(ctx: TaskContext):
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Prevent task module from loading

The new annotation def impl(ctx: TaskContext) evaluates TaskContext when the module is executed, but no such name is imported or defined. Running the file now raises NameError: name 'TaskContext' is not defined before the task can be registered (python bazel-diff.axl fails immediately), so the task cannot be used at all. Restore the original task_context symbol or defer annotation evaluation.

Useful? React with 👍 / 👎.

out = ctx.std.io.stdout
out.write("Building bazel-diff executable...\n")
build = ctx.build(
build = ctx.bazel.build(
ctx.args.bazel_diff_cli or "//tools:bazel-diff",
events = True,
bazel_flags = ["--build_runfile_links"],
build_events = True,
flags = ["--build_runfile_links"],
)
(bazel_diff_command, runfiles) = (None, None)
for event in build.events():
Expand Down
2 changes: 1 addition & 1 deletion example/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
Lorem Ipsum

~~~sh
output="$(aspect mytask)"
output="$(aspect affected)"

# Verify that it produces the expected output
echo "${output}" | grep -q "SUCCESS" || {
Expand Down
Loading