Skip to content

Conversation

@wchengru
Copy link
Contributor

@wchengru wchengru commented Aug 30, 2021

Which issue(s) does this change fix?

This PR is an update of #3029
It includes this RIE PR: aws/aws-lambda-runtime-interface-emulator#45
Local tests have been passed.

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wchengru wchengru mentioned this pull request Aug 30, 2021
8 tasks
@wchengru wchengru closed this Aug 30, 2021
@wchengru wchengru reopened this Aug 30, 2021
@jfuss
Copy link
Contributor

jfuss commented Aug 31, 2021

@wchengru Do we have an example of what ended up showing us something was wrong with RIE? My understanding was we (you) caught this manually?

If so, can we add a test for whatever that was? This was we have more confidence to catch this in the future.

@wchengru
Copy link
Contributor Author

wchengru commented Sep 1, 2021

@wchengru Do we have an example of what ended up showing us something was wrong with RIE? My understanding was we (you) caught this manually?

If so, can we add a test for whatever that was? This was we have more confidence to catch this in the future.

I added a new integration test case to catch it. The integration tests should catch this issue, but all local invoke integration tests are running with Canary. This new test case is to catch it before merging into develop.

@wchengru
Copy link
Contributor Author

wchengru commented Sep 1, 2021

@wchengru Do we have an example of what ended up showing us something was wrong with RIE? My understanding was we (you) caught this manually?
If so, can we add a test for whatever that was? This was we have more confidence to catch this in the future.

I added a new integration test case to catch it. The integration tests should catch this issue, but all local invoke integration tests are running with Canary. This new test case is to catch it before merging into develop.

According to offline discussion, we can keep the existing tests to catch the RIE binary issue in canary. Rolled back my changes on the tests cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants