-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: Update RIE to 1.1 and fix a bootstrap issue #3216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@wchengru Do we have an example of what ended up showing us something was wrong with RIE? My understanding was we (you) caught this manually? If so, can we add a test for whatever that was? This was we have more confidence to catch this in the future. |
I added a new integration test case to catch it. The integration tests should catch this issue, but all local invoke integration tests are running with Canary. This new test case is to catch it before merging into develop. |
According to offline discussion, we can keep the existing tests to catch the RIE binary issue in canary. Rolled back my changes on the tests cases. |
Which issue(s) does this change fix?
This PR is an update of #3029
It includes this RIE PR: aws/aws-lambda-runtime-interface-emulator#45
Local tests have been passed.
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.