ci: publish a GitHub Release (not a bare tag) + clarify record-release step#281
Merged
Conversation
Address review feedback (#279): the post-publish job sets master to the just-released version rather than advancing to a next dev version (matching awslabs/deequ). Rename the step 'Bump version and open PR' -> 'Record release version in master and open PR' and note the intent in the comment, so 'bump' isn't read as a next-dev bump.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kyraman
approved these changes
Jul 8, 2026
sudsali
changed the title
sudsali
added a commit
that referenced
this pull request
Jul 9, 2026
python-deequ historically ships GitHub Releases (v1.1.0..v1.6.0), not bare
tags. Replace the 'git tag + push' step with 'gh release create v${VERSION}
--target ${RELEASE_SHA} --generate-notes', which creates the tag AND the
Release page in one call, pinned to the published commit, after the PyPI
upload. Idempotent (skips if the release already exists).
Note: this change was intended for #281 but landed on that branch after it had
already merged, so it never reached master — hence this follow-up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #279 addressing review feedback, plus a release-convention fix.
Changes
1. Publish a GitHub Release, not a bare tag. python-deequ historically ships GitHub Releases (v1.1.0…v1.4.0, 2.0.0b1), but the workflow created only a bare
git tag. Switch the post-publish step togh release create v${VERSION} --target ${RELEASE_SHA} --generate-notes, which creates the tag and the Release page in one call, pinned to the published commit, after the PyPI upload. Idempotent (skips if the release already exists).2. Clarify the post-publish version step (per @kyraman's review on #279): the job sets
masterto the just-released version rather than advancing to a next dev version (matching awslabs/deequ). RenamedBump version and open PR→Record release version in master and open PR, with a comment stating it does NOT advance to a next-dev version.Notes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.