Skip to content

ci: publish a GitHub Release instead of a bare tag#282

Merged
sudsali merged 1 commit into
masterfrom
ci/publish-github-release
Jul 9, 2026
Merged

ci: publish a GitHub Release instead of a bare tag#282
sudsali merged 1 commit into
masterfrom
ci/publish-github-release

Conversation

@sudsali

@sudsali sudsali commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

The publish workflow creates a bare git tag on release, but python-deequ historically ships GitHub Releases (v1.1.0…v1.6.0). This switches the post-publish step to create a proper Release.

Change

Replace the git tag -a v${VERSION} + git push step with:

gh release create "v${VERSION}" --target "${RELEASE_SHA}" --title "v${VERSION}" --generate-notes

— which creates the tag and the Release page (auto-generated notes) in one call, pinned to the exact published commit, after the PyPI upload. Idempotent (skips if the release already exists).

Context

This change was written as part of #281 but was pushed to that branch after #281 had already merged, so it never reached master. This is the follow-up to land it. (The docs/rename portion of #281 did merge and is on master.)

Comment/step change only; no change to publish, versioning, or approval behavior.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

python-deequ historically ships GitHub Releases (v1.1.0..v1.6.0), not bare
tags. Replace the 'git tag + push' step with 'gh release create v${VERSION}
--target ${RELEASE_SHA} --generate-notes', which creates the tag AND the
Release page in one call, pinned to the published commit, after the PyPI
upload. Idempotent (skips if the release already exists).

Note: this change was intended for #281 but landed on that branch after it had
already merged, so it never reached master — hence this follow-up PR.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.


Generated by AI (model: us.anthropic.claude-opus-4-8, prompt: 295226dd) — may not be fully accurate. Reply if this doesn't help.
Reviewed by Shadow · github.com/sudsali/shadow

@sudsali sudsali merged commit 0e3be7f into master Jul 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants