Skip to content

fix: set correct linking location for yarn_install using package.json from external repository - #3442

Merged
gregmagolan merged 1 commit into
bazel-contrib:stablefrom
gregmagolan:fix_yarn_install_for_external_package_json
May 3, 2022
Merged

fix: set correct linking location for yarn_install using package.json from external repository#3442
gregmagolan merged 1 commit into
bazel-contrib:stablefrom
gregmagolan:fix_yarn_install_for_external_package_json

Conversation

@gregmagolan

@gregmagolan gregmagolan commented May 3, 2022

Copy link
Copy Markdown
Collaborator

Fixes #3323

Verified on repro repository, https://github.com/mhevery/repro-bazel-nested-project

gregs-mbp:repro-bazel-nested-project greg$ bazel build @child//packages/core
INFO: Analyzed target @child//packages/core:core (12 packages loaded, 99 targets configured).
INFO: Found 1 target...
Target @child//packages/core:core up-to-date:
  bazel-bin/external/child/packages/core/main.js
INFO: Elapsed time: 0.447s, Critical Path: 0.01s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
gregs-mbp:repro-bazel-nested-project greg$ cd child
gregs-mbp:child greg$ bazel build //packages/core
INFO: Analyzed target //packages/core:core (10 packages loaded, 94 targets configured).
INFO: Found 1 target...
Target //packages/core:core up-to-date:
  bazel-bin/packages/core/main.js
INFO: Elapsed time: 2.755s, Critical Path: 0.01s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action

@gregmagolan
gregmagolan marked this pull request as ready for review May 3, 2022 19:59
@gregmagolan gregmagolan changed the title fix: fix linking location for yarn_install using package.json from external repository fix: set correct linking location for yarn_install using package.json from external repository May 3, 2022

@thesayyn thesayyn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's ridiculously simple.

@gregmagolan
gregmagolan merged commit 55a84d1 into bazel-contrib:stable May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

local_repository installs node_modules in location not reachable by tsconfig.json

3 participants