Skip to content

fix: set correct linking location for yarn_install using package.json from external repository #3442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregmagolan merged 1 commit into from
May 3, 2022
Merged

fix: set correct linking location for yarn_install using package.json from external repository #3442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions internal/npm_install/npm_install.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,11 +449,14 @@ def _create_build_files(repository_ctx, rule_type, node, lock_file, generate_loc
fail("link target must be label of form '@wksp//path/to:target', '@//path/to:target' or '//path/to:target'")
validated_links[k] = v

package_json_dir = paths.dirname(paths.normalize(paths.join(repository_ctx.attr.package_json.package, repository_ctx.attr.package_json.name)))
package_json_dir = paths.dirname(paths.normalize(paths.join(
repository_ctx.attr.package_json.package,
repository_ctx.attr.package_json.name,
)))
package_path = repository_ctx.attr.package_path
if not package_path:
# By default the package_path is the directory of the package.json file
package_path = package_json_dir
package_path = paths.join(repository_ctx.attr.package_json.workspace_root, package_json_dir)
elif package_path == "/":
# User specified root path
package_path = ""
Expand Down