Conversation
Contributor
Author
|
I'm just opening the PR for now to test things, I'd like to experiment with adding some better test coverage for this case. |
mattmoor
force-pushed
the
fix-28
branch
2 times, most recently
from
May 11, 2017 04:32
73314ba to
a14fa6d
Compare
Contributor
Author
|
@damienmg Do you have any good examples of how I might ~embed a test like I have in |
damienmg
approved these changes
May 11, 2017
Contributor
|
I don't really understand what you are asking for, can you give an example of what you would like to do? |
Contributor
Author
|
tl;dr bazelbuild/bazel#2751 I am going to move these files into a shell script that will run end to end tests and invoke it from Travis. |
Switch to using the new relaxed naming to fix the linked issue. Fixes: #28
sudarshang
pushed a commit
to sudarshang/rules_docker
that referenced
this pull request
Sep 26, 2019
…azelbuild#29) Updates the Java example BUILD file to match the Java tutorial text (reverts bazelbuild/bazel@08e34e3).
sudarshang
pushed a commit
to sudarshang/rules_docker
that referenced
this pull request
Sep 26, 2019
… text. (bazelbuild#29)" (bazelbuild#30) This reverts commit 53c7f3d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to using the new relaxed naming to fix the linked issue.
Fixes: #28