Skip to content

Save Spotify album_id and track_id as flexible attributes - #4348

Merged
sampsyo merged 7 commits into
beetbox:masterfrom
arsaboo:spotify_id
May 8, 2022
Merged

Save Spotify album_id and track_id as flexible attributes#4348
sampsyo merged 7 commits into
beetbox:masterfrom
arsaboo:spotify_id

Conversation

@arsaboo

@arsaboo arsaboo commented May 8, 2022

Copy link
Copy Markdown
Contributor

Description

Partially Fixes #4347.

Added additional keys to save Spotify track_id and album_id as flexible attributes.

To Do

  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

@sampsyo

sampsyo commented May 8, 2022

Copy link
Copy Markdown
Member

Cool!! Thanks for getting this started! Have you had a chance to try it out? Does it work as expected?

If it does, a next step would be to craft a quick changelog entry describing the new feature.

@arsaboo

arsaboo commented May 8, 2022

Copy link
Copy Markdown
Contributor Author

Yes, it does. Here's the output of the item_attributes table that has all the information.

image

@sampsyo

sampsyo commented May 8, 2022

Copy link
Copy Markdown
Member

Awesome; thanks for adding this! Seems like a good first step!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spotify spotify plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants