Extend Spotify plugin to obtain (popularity and audio features) track attributes - #4352
Conversation
|
@sampsyo I was thinking that instead of spotify:
client_id: SPOTIFY_CLIENT_ID
client_secret: SPOTIFY_CLIENT_SECRET
popularity: yes
popularity_overwrite: no
audio_features: no
audio_features_overwrite: no |
sampsyo
left a comment
There was a problem hiding this comment.
Awesome; looking good so far! Here are a few suggestions/questions.
Do you also think you might be able to add to the docs for the plugin to describe the new command? A changelog entry would also be super helpful.
Co-authored-by: Adrian Sampson <adrian@radbox.org>
Co-authored-by: Adrian Sampson <adrian@radbox.org>
Co-authored-by: Adrian Sampson <adrian@radbox.org>
|
Thanks for the review @sampsyo. Addressed all the comments and updated the documents/changelog. |
|
Just here to say woohoo! Very nice feature! Thanks to the submitter 💣💥 |
|
Thanks @JOJ0 I have a few additional features in mind once this PR gets merged. |
|
Looks good to me! @sampsyo all your previous comments have been addressed, any other concerns? Or can we go ahead and merge this? |
sampsyo
left a comment
There was a problem hiding this comment.
Nice!! This looks really great. Thank you for seeing this through!!
This PR extends the
spotifyplugin to add another commandbeet spotifysyncto obtain all the audio features available for a track. This includes thepopularityinformation andaudio_features. The followingaudio_featuresare included: acousticness, danceability, energy, instrumentalness, key, liveness, loudness, mode, speechiness, tempo, time_signature, valence. See details here.This command only processes tracks that already have the
spotify_track_id(which was introduced in #4348). So, the workflow will be to runbeet importto obtain thespotify_track_id. This information can then be used to runbeet spotifysync.Fixes #4347 #3578 #4094
optional config:
To Do
docs/to describe it.)docs/changelog.rstnear the top of the document.)