Update github workflows - #5248
Conversation
snejus
left a comment
snejus
left a comment
There was a problem hiding this comment.
Added a couple of comments regarding python versions and testing
| - name: Check external links in docs | ||
| run: | | ||
| tox -e links | ||
|
|
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: 3.9-dev | ||
| python-version: 3.12 |
There was a problem hiding this comment.
I think it may be best to test the earliest supported version
| matrix: | ||
| platform: [ubuntu-latest, windows-latest] | ||
| python-version: ['3.7', '3.8', '3.9', '3.x'] | ||
| python-version: ['3.8', '3.9', '3.10', '3.11', '3.12'] |
There was a problem hiding this comment.
Happy to test the most recent python versions here! We probably want to include a note in the changelog as well.
On the other hand, I think we want to continue testing 3.7 before it's been properly removed from the codebase, see the relevant ticket here: #5222
## Description Fixes #5222. Drop Python 3.7. `pyupgrade` is responsible for most of the changes in the code. I undid some of the bits it attempted to update that aren't strictly necessary: 1. Converting `List/Dict/Tuple` -> `list/dict/tuple` in modules that have `from __future__ import annotations` import. This should be done in a separate PR, and for all modules 2. Converting some `.format(` calls to f-strings. It didn't do it consistently, and it should also be done in a separate PR, I believe. Python upgrade unblocks several other PRs, for example #5266 and #5248.
|
@matlads Python 3.7 has now been dropped, so try updating your PR! |
|
Might be a tool PR? Sometimes people go through repos with automated tools to make easy commits and open PRs to try and boost their GitHub profile/resume. Showing that you've contributed to a popular repo, seem more active. Might not be a bad idea to update some workflows though, as long as they don't break anything. |
Will do. |
|
Do you want to reopen this PR? |
No. I'll make a new one. |
|
Please don't. This has already been created, just reopen and commit changes. |
3 participants
Description
Updates some github workflows to the latest versions
(...)
To Do
Documentation.Changelog.Tests.