Upgrade to Python 3.8 / drop Python 3.7 - #5283
Merged
Merged
Conversation
On Python 3.8 this is irrelevant since in all cases tox v4 will be installed which works fine.
snejus
force-pushed
the
upgrade-to-python38
branch
from
June 5, 2024 03:41
e0c25f7 to
65bfbda
Compare
Serene-Arc
approved these changes
Jun 5, 2024
Serene-Arc
left a comment
Serene-Arc
left a comment
Contributor
There was a problem hiding this comment.
Changes seem good to me. Nice that 3.8 has its own lazy property functionality in functools.
This was referenced Jun 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5222.
Drop Python 3.7.
pyupgradeis responsible for most of the changes in the code. I undid some of the bits it attempted to update that aren't strictly necessary:List/Dict/Tuple->list/dict/tuplein modules that havefrom __future__ import annotationsimport. This should be done in a separate PR, and for all modules.format(calls to f-strings. It didn't do it consistently, and it should also be done in a separate PR, I believe.Python upgrade unblocks several other PRs, for example #5266 and #5248.
To Do
docs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)