build(ci): let the build checks report on every pull request - #83
Merged
Conversation
A path-filtered check never reports on a pull request that misses its paths, and a required check that never reports blocks the merge for ever. So 'Build & Test' and 'Build API image & scan' could not be required — which is how auto-merge landed two dependency bumps today while the container build was failing, and left dapper unable to build its image. The filter is removed from pull_request only. The push trigger keeps it: there is no reason to rebuild and redeploy on a docs edit, and nothing gates on a push. The cost is a build on every pull request, roughly a minute. The alternative is a required-checks list that omits the checks that matter, which is the shape of protection this review has spent the day removing.
main's container build has been failing since #75 merged. Dependabot updated TodoApp.Infrastructure's lock to System.IdentityModel.Tokens.Jwt 8.22.0 and left WebApi, UnitTests and IntegrationTests on 8.19.2, so restore refuses in locked mode with NU1004. Nothing caught it, because 'Build API image & scan' was path-filtered and no pull request since then touched src/. Removing that filter in this same branch is what surfaced it — on the first run, which is the argument for the change.
bgard68
added a commit
that referenced
this pull request
Aug 2, 2026
Mirrors #83 on main, for the branch that would carry the API if it is ever switched in. A path-filtered check never reports on a pull request that misses its paths, and a required check that never reports blocks the merge for ever — so 'Build & Test' and 'Build API image & scan' could not be required here. That is how auto-merge landed two dependency bumps while the container build was failing, and left this branch unable to build its image until #82. Removed from pull_request only; the push trigger keeps its filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for requiring the checks that matter — and the direct fix for today's only breakage.
The problem
A path-filtered check never reports on a pull request that misses its paths. A required check that never reports blocks the merge for ever. So
Build & TestandBuild API image & scancould not be added to the required list.That is how auto-merge landed #76 and #79 while
Build API image & scanwas failing, leavingdapperunable to build its image until #82 regenerated the lock files. Auto-merge waited for required checks; there were none to wait for.The change
paths:removed frompull_requestonly. Thepushtrigger keeps its filter — there is no reason to rebuild and redeploy on a docs edit, and nothing gates on a push.The cost
A build on every pull request, roughly a minute. The alternative is a required-checks list that omits the checks that actually matter — which is the shape of protection this review has spent the day taking apart.
Once this lands: add the required status checks, then re-enable auto-merge.