build(ci): let the build checks report on every pull request - #85
Merged
Conversation
Mirrors #83 on main, for the branch that would carry the API if it is ever switched in. A path-filtered check never reports on a pull request that misses its paths, and a required check that never reports blocks the merge for ever — so 'Build & Test' and 'Build API image & scan' could not be required here. That is how auto-merge landed two dependency bumps while the container build was failing, and left this branch unable to build its image until #82. Removed from pull_request only; the push trigger keeps its filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors #83 on
main, for the branch that would carry the API if it is ever switched in.A path-filtered check never reports on a pull request that misses its paths, and a required check that never reports blocks the merge for ever — so
Build & TestandBuild API image & scancould not be required here.That is exactly how auto-merge landed #76 and #79 while the container build was failing, leaving this branch unable to build its image until #82 regenerated the lock files.
paths:removed frompull_requestonly acrossapi-ci-cd.yml,container-build.ymlandscripts-lint.yml. Thepushtrigger keeps its filter — no reason to rebuild on a docs edit.Required status checks get added once this lands, and verified the way
main's were: by opening a deliberately failing pull request and confirming the merge is refused.