fix(core): render branded page for /404 instead of Vercel default#2903
Closed
malewis5 wants to merge 1 commit intobigcommerce:canaryfrom
Closed
fix(core): render branded page for /404 instead of Vercel default#2903malewis5 wants to merge 1 commit intobigcommerce:canaryfrom
malewis5 wants to merge 1 commit intobigcommerce:canaryfrom
Conversation
Visiting /404 directly shows the default Vercel black screen because Next.js special-cases this path with a pre-rendered static 404.html, bypassing the [locale] segment entirely. Fix by splitting the layout into a true root layout (app/layout.tsx) owning <html>, <body>, fonts, and globals.css, and converting the locale layout into a nested layout. A new root not-found.tsx renders a minimal branded 404 page for this edge case. Made-with: Cursor
|
@malewis5 is attempting to deploy a commit to the BigCommerce Platform Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visiting /404 directly shows the default Vercel black screen because
Next.js special-cases this path with a pre-rendered static 404.html,
bypassing the [locale] segment entirely.
Fix by splitting the layout into a true root layout (app/layout.tsx)
owning , , fonts, and globals.css, and converting the
locale layout into a nested layout. A new root not-found.tsx renders
a minimal branded 404 page for this edge case.