fix(core): adds root-level not found page#2947
Merged
Conversation
🦋 Changeset detectedLatest commit: c48e1bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Bundle Size ReportComparing against baseline from No bundle size changes detected. |
jorgemoya
force-pushed
the
catalyst-689-fix-404-prod
branch
from
9643796 to
188baea
Compare
jorgemoya
force-pushed
the
catalyst-689-fix-404-prod
branch
from
188baea to
8001934
Compare
jorgemoya
force-pushed
the
catalyst-689-fix-404-prod
branch
from
8001934 to
b56c360
Compare
jorgemoya
force-pushed
the
catalyst-689-fix-404-prod
branch
from
b56c360 to
c48e1bb
Compare
Contributor
Unlighthouse Performance Comparison — VercelComparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores. Summary ScoreAggregate score across all categories as reported by Unlighthouse.
Category Scores
Core Web Vitals
|
chanceaclark
approved these changes
Mar 23, 2026
jorgemoya
added a commit
that referenced
this pull request
Apr 24, 2026
The root <html> tag was hardcoded to lang="en" for all locales because #2947 moved <html>/<body> ownership from app/[locale]/layout.tsx up to a new root app/layout.tsx to enable the branded /404 page. That fix solved the 404 but regressed the lang attribute. Adopt next-intl's documented pattern: - app/layout.tsx is now a passthrough (returns children) — required by Next.js but owns no markup. - app/[locale]/layout.tsx owns <html lang={locale}> and <body> again, so localized pages get the correct language. - app/not-found.tsx owns its own <html>/<body>, fonts, and global CSS so the branded 404 still renders for non-localized requests. Verified parity with canary on runtime 404 behavior (both serve the Next.js error-fallback shell for dynamic 404s) and clean output in the prerendered _not-found.html static file. Fixes LTRAC-578 Co-Authored-By: Claude <noreply@anthropic.com>
chanceaclark
pushed a commit
that referenced
this pull request
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
When navigating to /404 in production, Catalyst renders the default Vercel/Next.js error screen instead of a branded page. This happens because not-found.tsx only exists inside the [locale] segment, so routes that fall outside that
segment (like the root /404) have no custom not-found page.
This PR:
Testing
Migration