Skip to content

chore(ci): fix two stale release.yml comments (Item 38) - #47

Merged
bilbospocketses merged 1 commit into
masterfrom
chore/release-yml-comments
Jun 11, 2026
Merged

chore(ci): fix two stale release.yml comments (Item 38)#47
bilbospocketses merged 1 commit into
masterfrom
chore/release-yml-comments

Conversation

@bilbospocketses

Copy link
Copy Markdown
Owner

Closes the release.yml half of the Item 38 todo — two stale comments, no workflow behavior change.

  • The pre-seed step comment listed adb, scrcpy, sqlite3, go2rtc, but scrcpy was dropped from the seed set in chore(deps): remove orphaned scrcpy dependency #37. Now reads adb, sqlite3, go2rtc.
  • The Restore step carried a "No .sln in this repo" comment, which is stale — ControlMenu.sln has existed since Velopack Phase 1. The per-project restore is deliberate (mirrors local-pack.ps1), so the comment now says that rather than claiming the sln is missing.

Surfaced while touching release.yml for the v1.1.1 vpk lockstep fix (#46); the todo said to fix these opportunistically next time the file was touched.

- Pre-seed step comment listed `adb, scrcpy, sqlite3, go2rtc`; scrcpy was
  dropped in #37, so the seeded set is `adb, sqlite3, go2rtc`.
- "No .sln in this repo" is stale (ControlMenu.sln exists since Velopack
  Phase 1). The per-project restore is deliberate, so the comment now says
  so instead of claiming the sln is absent.

Comment-only, no workflow behavior change.
@bilbospocketses
bilbospocketses enabled auto-merge (squash) June 11, 2026 19:32
@bilbospocketses
bilbospocketses merged commit 5391297 into master Jun 11, 2026
8 checks passed
@bilbospocketses
bilbospocketses deleted the chore/release-yml-comments branch June 11, 2026 19:34
bilbospocketses added a commit that referenced this pull request Jun 24, 2026
… vendored icons (#76)

* docs(plan): audit MINOR mop-up + follow-ups (5-PR batch)

* fix(frontend): audit MINOR cleanup #42-#47 + #57

- #43 define semantic --*-bg / --*-text theme tokens (light + dark); dark mode
  now resolves real values instead of silently using the light-mode fallback
- #44 dedup byte-identical .dialog/.modal CSS; theme-aware pill :hover via color-mix
- #45 re-key scrcpy settings modal to app theme tokens (was unset Bootstrap
  --bs-*); the modal now follows light/dark instead of always-dark fallbacks
- #46 fix stale "conic" comment (the code is four linear gradients)
- #47 home-tiles.js batches reads then writes (no per-card layout thrash);
  remove dead .home-module-* CSS from the reverted tile experiment
- #42 subnets.html Close-tab link no longer traps a non-script-opened tab
- #57 vendor bootstrap-icons 1.11.3 (CSS + woff2/woff) under wwwroot/lib;
  drop the jsDelivr CDN dependency (works offline, closes the no-SRI gap)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant