Audit MINOR cleanup #42-#47, #57: theme tokens, scrcpy-modal theming, vendored icons - #76
Merged
Merged
Conversation
- #43 define semantic --*-bg / --*-text theme tokens (light + dark); dark mode now resolves real values instead of silently using the light-mode fallback - #44 dedup byte-identical .dialog/.modal CSS; theme-aware pill :hover via color-mix - #45 re-key scrcpy settings modal to app theme tokens (was unset Bootstrap --bs-*); the modal now follows light/dark instead of always-dark fallbacks - #46 fix stale "conic" comment (the code is four linear gradients) - #47 home-tiles.js batches reads then writes (no per-card layout thrash); remove dead .home-module-* CSS from the reverted tile experiment - #42 subnets.html Close-tab link no longer traps a non-script-opened tab - #57 vendor bootstrap-icons 1.11.3 (CSS + woff2/woff) under wwwroot/lib; drop the jsDelivr CDN dependency (works offline, closes the no-SRI gap)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR of the audit MINOR mop-up — the frontend/static cleanup cluster. Seven findings from the 2026-06-14 review, all cosmetic or static-asset:
--success-bg/--danger-bg/--warning-bg/--info-bg(+ matching-text) theme tokens. They were referenced across 11 component stylesheets but never defined, so every status badge/alert silently used its hardcoded light-mode fallback — even in dark mode. Light values match the old fallbacks exactly (light mode is pixel-identical); dark mode now gets proper dark-tinted badges.--bs-*variables, so it rendered with hardcoded dark fallbacks regardless of theme. Re-keyed to the app's theme tokens so it follows light/dark like everything else. (Visible change: the modal is now light in light mode.).dialog-*/.modal-*rule pairs; the pill-button hover now derives from the theme accent viacolor-mixinstead of hardcoded Bootstrap hex (which was wrong in dark mode).home-tiles.jsbatches itsscrollHeightreads before its style writes (was thrashing layout once per card). Removed dead.home-module-*CSS left from the reverted tile experiment.wwwroot/lib/instead of pulling it from jsDelivr with no SRI. Icons work offline now, and there is no third-party runtime fetch.682 tests still green; clean build. Verified at runtime: icons load locally with zero CDN requests, the theme tokens resolve correctly in both light and dark, home tiles still lay out. Independent whole-branch review came back clean — the only notes were two pre-existing dark-mode palette contrast values this PR exposes rather than introduces.
Plan:
docs/superpowers/plans/2026-06-24-audit-minor-mopup.md(PR 1 of 5).