[hasura] fix: thread delete and user permissions duplicate

[AndlerRL]

Summary by Sourcery

Fix thread deletion and user permissions duplication issues in the Hasura service. Introduce new features for updating user personality and managing chat loading states. Enhance the ChatList component and refactor the Chat component for better performance and readability. Improve password strength validation and refactor email templates. Add detailed documentation and tests for new functionalities.

New Features:

• Introduce a new function to update user personality, allowing users to update their bio, favorite topic, and profile picture.
• Add a new ChatLoadingState component to handle different loading states in the chat interface.
• Implement a new MessagePairs component to manage and display chat message pairs.
• Add a new UserThreadPanel component to manage and display user threads with search and pagination capabilities.

Bug Fixes:

• Fix thread deletion and user permissions duplication issues in the Hasura service.

Enhancements:

• Improve error handling and logging in various functions, including fetchChatbotMetadata and approveThread.
• Enhance the ChatList component to better manage message pairs and display them in an accordion format.
• Refactor the Chat component to improve performance and readability, including state management and message handling.
• Update the password strength calculation to include Unicode characters and improve validation.
• Refactor email templates for password reset and verification to improve maintainability.

Documentation:

• Add detailed comments and documentation to various components and functions, improving code readability and maintainability.

Tests:

• Add tests for new user personality update functionality and chat loading states.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
masterbots	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 10, 2024 7:53am

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR implements several major improvements to the Masterbots.ai application, including thread deletion and user permissions fixes, code organization improvements, and enhanced UI components. The changes focus on better state management, improved type safety, and cleaner component architecture.

Updated class diagram for Hasura service

classDiagram
    class HasuraService {
        +getChatbots()
        +getThreads()
        +createThread()
        +getChatbot()
        +getBrowseThreads()
        +getThreadsWithoutJWT()
        +UpdateThreadVisibility()
        +fetchChatbotMetadata()
        +approveThread()
        +getUserRoleByEmail()
        +deleteThread()
        +getUnapprovedThreads()
        +getUserBySlug()
        +updateUserPersonality()
        +subtractChatbotMetadataLabels()
    }
    class UpdateUserArgs {
        +pkColumns: Object
        +_set: Object
    }
    HasuraService --> UpdateUserArgs
    note for HasuraService "This class handles various operations related to threads, users, and chatbots in the Hasura service."

Loading

Updated class diagram for ChatList component

classDiagram
    class ChatList {
        +messages: Message[]
        +chatbot: Chatbot
        +isThread: boolean
        +className: string
        +chatContentClass: string
        +chatTitleClass: string
        +chatArrowClass: string
        +containerRef: React.RefObject
        +isNearBottom: boolean
        +isLoadingMessages: boolean
        +sendMessageFn(message: string)
    }
    class MessagePair {
        +userMessage: Message
        +chatGptMessage: Message[]
    }
    ChatList --> MessagePair
    note for ChatList "This component renders a chat interface, managing message pairs and displaying them in an accordion format."

Loading

Updated class diagram for ThreadProvider

classDiagram
    class ThreadProvider {
        +isOpenPopup: boolean
        +activeThread: Thread
        +isNewResponse: boolean
        +sectionRef: React.MutableRefObject
        +isAtBottom: boolean
        +randomChatbot: Chatbot
        +isAdminMode: boolean
        +webSearch: boolean
        +loadingState: ChatLoadingState
        +activeTool: AiToolCall
        +setActiveThread(Thread)
        +setIsNewResponse(boolean)
        +setIsOpenPopup(boolean)
        +setActiveTool(AiToolCall)
        +setLoadingState(ChatLoadingState)
        +setWebSearch(boolean)
    }
    note for ThreadProvider "This provider manages the state and context for chat threads, including active threads and loading states."

Loading

File-Level Changes

Change	Details	Files
Refactored thread management and user permissions system	Added thread deletion functionality with proper user authorization checks Fixed user permissions duplicate issues Improved thread visibility toggle functionality Enhanced thread state management with better TypeScript types	apps/masterbots.ai/services/hasura/hasura.service.ts apps/masterbots.ai/components/routes/thread/thread-publicity-switch.tsx apps/masterbots.ai/lib/hooks/use-thread.tsx
Enhanced UI components and user experience	Improved chat interface with better message handling Added responsive design improvements for mobile devices Implemented new password strength meter component Added web search integration in chat interface	apps/masterbots.ai/components/routes/chat/chat-list.tsx apps/masterbots.ai/components/routes/chat/chat-panel.tsx apps/masterbots.ai/components/shared/password-strength-meter.tsx apps/masterbots.ai/components/ui/button.tsx
Improved authentication and user profile management	Enhanced email verification system Added user profile customization features Improved password reset functionality Added user slug support for profile URLs	apps/masterbots.ai/lib/email.ts apps/masterbots.ai/app/auth/signup/page.tsx apps/masterbots.ai/app/api/auth/reset-password/route.ts apps/masterbots.ai/auth.ts
Code organization and infrastructure improvements	Reorganized action handlers into separate directories Improved error handling and type safety Updated dependencies and configuration files Added new environment variables and configuration options	apps/masterbots.ai/app/actions/ai-main-call.ts apps/masterbots.ai/app/actions/subscriptions.ts apps/masterbots.ai/package.json apps/masterbots.ai/next.config.js

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sourcery-ai]

Hey @AndlerRL - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

• Add request timeout and CSRF protection to admin API calls (link)
• Empty JWT string passed to getThread is a security concern (link)

Overall Comments:

• Consider the performance implications of removing the 'edge' runtime configuration. While this simplifies deployment, it may impact latency and scalability. Please document the reasoning behind this architectural change.

Here's what I looked at during the review

• 🟡 General issues: 7 issues found
• 🔴 Security: 2 blocking issues
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[AndlerRL]

Hey @AndlerRL - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

• Add request timeout and CSRF protection to admin API calls (link)
• Empty JWT string passed to getThread is a security concern (link)

Overall Comments:

• Consider the performance implications of removing the 'edge' runtime configuration. While this simplifies deployment, it may impact latency and scalability. Please document the reasoning behind this architectural change.

Here's what I looked at during the review
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

We are addressing it ASAP. Issues has been created to track this.