chore: seeds upt

[AndlerRL]

Summary by Sourcery

Add a new SQL seed file for Supabase production data, update the database URL in Docker Compose for Hasura, and clean up existing seed data by removing specific entries.

New Features:

• Introduce a new SQL seed file for Supabase production data, which includes the creation of tables, sequences, and initial data inserts for categories, chatbots, messages, and user information.

Enhancements:

• Update the Docker Compose configuration to use a new PostgreSQL database URL for Hasura, with the previous URL commented out for reference.

Chores:

• Remove several entries from existing SQL seed files related to messages and threads, likely to clean up or update the initial data set.

Summary by CodeRabbit

• New Features
  • Introduced a new is_approved column in the threads table to manage thread approval status.
  • Streamlined dataset for threads and messages by removing specific entries to enhance relevance.
• Changes
  • Updated database connection from a local PostgreSQL instance to a cloud-based Supabase solution, improving data accessibility.
  • Enhanced thread browsing functionality to only display approved and public threads.
  • Adjusted default visibility settings for threads to improve privacy and control.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
masterbots	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 15, 2024 11:02pm

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request updates the database schema and data for the MasterBots application. It includes changes to the docker-compose.yml file to use a new database URL, adds a new SQL file for production data, and makes various modifications to existing database tables and data.

File-Level Changes

Change	Details	Files
Updated docker-compose.yml to use a new database URL	Changed HASURA_GRAPHQL_DATABASE_URL to use a Supabase PostgreSQL database Commented out the old local database URL	docker-compose.yml
Added new SQL file for production data	Created supabase-prod-data.sql file containing database schema and initial data	supabase-prod-data.sql
Modified existing database tables and data	Updated various tables including category, chatbot, message, prompt, thread, and user Added new data entries to existing tables Modified some table constraints and relationships	apps/hasura/seeds/masterbots/1724271332200_init_messages_seeds.sql apps/hasura/seeds/masterbots/1724271272084_init_threads_seeds.sql

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes consist of the removal of several INSERT statements from SQL seed files related to the public.thread and public.message tables, reducing the initial dataset for the application. Additionally, a new is_approved column has been added to the public.thread table, and the database connection string in the docker-compose.yml file has been modified to point to a cloud-based PostgreSQL instance on Supabase, replacing the previous local database connection.

Changes

File Path	Change Summary
apps/hasura/seeds/masterbots/1724271272084_init_threads_seeds.sql apps/hasura/seeds/masterbots/1724271332200_init_messages_seeds.sql	Removed multiple INSERT statements from the public.thread and public.message tables, reducing the dataset.
docker-compose.yml	Modified the HASURA_GRAPHQL_DATABASE_URL to connect to a cloud PostgreSQL instance on Supabase.
apps/hasura/migrations/masterbots/1726440714574_alter_table_public_thread_add_column_is_approved/up.sql apps/hasura/migrations/masterbots/1726440714574_alter_table_public_thread_add_column_is_approved/down.sql	Added is_approved boolean column to public.thread table, allowing null values with a default of false.
apps/hasura/migrations/masterbots/1726440734382_alter_table_public_thread_alter_column_is_public/up.sql apps/hasura/migrations/masterbots/1726440734382_alter_table_public_thread_alter_column_is_public/down.sql	Modified default value of is_public column in public.thread table to true and false respectively.
apps/masterbots.ai/services/hasura/hasura.service.ts	Adjusted whitespace in getThreads function; added condition to getBrowseThreads to filter by isApproved: { _eq: true }.

Possibly related PRs

• chore: seeds upt #269: The changes in this PR involve the removal of INSERT statements from the public.thread table and the addition of the is_approved column, which directly relates to the changes made in the main PR regarding the same SQL seed file and the introduction of the is_approved column.

Poem

🐇 In the meadow where threads once grew,
The rabbit hops, with a joyful view.
Messages trimmed, a clearer path,
To a cloud above, we’ll do the math.
With each little change, we dance and play,
Celebrating seeds in a brand new way! 🌱✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sourcery-ai]

Hey @AndlerRL - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

• Potential hard-coded password found. (link)
• Potential hard-coded password found. (link)
• Potential hard-coded password found. (link)
• Potential hard-coded password found. (link)
• Potential hard-coded password found. (link)
• Potential hard-coded password found. (link)

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🔴 Security: 6 blocking issues
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1573421 and 37f820b.

Files selected for processing (5)

• apps/hasura/migrations/masterbots/1726440714574_alter_table_public_thread_add_column_is_approved/down.sql (1 hunks)
• apps/hasura/migrations/masterbots/1726440714574_alter_table_public_thread_add_column_is_approved/up.sql (1 hunks)
• apps/hasura/migrations/masterbots/1726440734382_alter_table_public_thread_alter_column_is_public/down.sql (1 hunks)
• apps/hasura/migrations/masterbots/1726440734382_alter_table_public_thread_alter_column_is_public/up.sql (1 hunks)
• apps/masterbots.ai/services/hasura/hasura.service.ts (2 hunks)

Additional comments not posted (5)

apps/hasura/migrations/masterbots/1726440734382_alter_table_public_thread_alter_column_is_public/up.sql (1)

1-1: LGTM! The SQL statement is valid and the change is straightforward.

Setting the default value of is_public to true for new thread records is a reasonable choice, as it promotes user engagement by making threads publicly visible by default. This aligns with the insights provided in the AI-generated summary.

A few additional considerations:

• Ensure that the application logic and user interface are updated to handle this new default behavior consistently.
• Consider whether there are any existing threads that should remain private by default and handle them accordingly (e.g., through a separate migration script or manual updates).
• Monitor user feedback and engagement metrics after deploying this change to validate its impact and make any necessary adjustments.

Overall, this change seems beneficial for enhancing thread visibility and user engagement.

apps/hasura/migrations/masterbots/1726440734382_alter_table_public_thread_alter_column_is_public/down.sql (1)

1-1: LGTM! The SQL statement is correct and aligns with the PR objectives.

The ALTER TABLE statement correctly modifies the default value of the is_public column in the thread table to 'false'. This change ensures that any new records inserted into the thread table will have is_public set to 'false' unless explicitly specified otherwise.

As mentioned in the AI-generated summary, this adjustment may impact how threads are treated in terms of visibility and access control, potentially enhancing privacy by default for newly created threads. It's a good practice to set default values that prioritize privacy and security.

apps/hasura/migrations/masterbots/1726440714574_alter_table_public_thread_add_column_is_approved/up.sql (1)

1-2: LGTM!

The SQL statement is well-structured and follows the correct syntax for altering a table and adding a new column. The is_approved column is a valuable addition to the thread table, as it allows for better management and filtering of threads based on their approval status.

Just ensure that the application code is updated to handle this new column appropriately.

apps/masterbots.ai/services/hasura/hasura.service.ts (2)

117-117: Skipping review.

The changes are only whitespace adjustments and do not require a review.

---

436-437: LGTM!

The new condition refines the selection criteria to only return threads that are both public and approved, which aligns with the expected behavior.

To ensure the correctness of this change, please verify that the isApproved field is being set correctly in the database for the threads that should be visible for browsing.

Run the following script to verify the isApproved field:

Verification successful

---

Verification successful, with a suggestion for improvement

The code change in the getBrowseThreads function is verified to be correct and consistent with the database schema. Both isPublic and isApproved fields exist in the thread table, as evidenced by the migration files.

However, we noticed a lack of specific test coverage for these fields. To improve the robustness of the codebase, consider adding unit tests that verify the behavior of the getBrowseThreads function with various combinations of isPublic and isApproved values.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the `isApproved` field is set correctly for threads that should be visible for browsing.

# Test: Search for threads that are public but not approved. Expect: No results.
rg --type sql -A 5 $'SELECT \* FROM thread WHERE isPublic = true AND isApproved = false'

Length of output: 89

---

Script:

#!/bin/bash
# Description: Search for usage of isPublic and isApproved fields in the codebase

# Search for SQL queries related to the thread table
echo "SQL queries related to the thread table:"
rg --type sql "FROM thread"

# Search for TypeScript/JavaScript code interacting with thread table
echo "\nTypeScript/JavaScript code interacting with thread table:"
rg --type ts --type js "thread.*isPublic|thread.*isApproved"

# Search for database migration or schema files
echo "\nDatabase migration or schema files:"
fd -e sql -e prisma

# Search for test files related to thread visibility and approval
echo "\nTest files related to thread visibility and approval:"
rg --type ts --type js "test.*thread.*isPublic|test.*thread.*isApproved"

Length of output: 11219