Skip to content

Display plain "Inbound" in peer details#203

Merged
jonasschnelli merged 1 commit into
bitcoin-core:masterfrom
jonatack:display-plain-inbound-and-add-release-notes
Feb 5, 2021
Merged

Display plain "Inbound" in peer details#203
jonasschnelli merged 1 commit into
bitcoin-core:masterfrom
jonatack:display-plain-inbound-and-add-release-notes

Conversation

@jonatack

@jonatack jonatack commented Jan 30, 2021

Copy link
Copy Markdown
Member

Alternative version to #201.

@maflcko maflcko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review ACK ff8afeb

Thanks

Comment thread doc/release-notes-162-163.md Outdated
@jonatack jonatack changed the title gui: display plain "Inbound" in peer details, add #162/#163 release notes gui: display plain "Inbound" in peer details Jan 30, 2021
@jonatack
jonatack force-pushed the display-plain-inbound-and-add-release-notes branch from ff8afeb to 506e658 Compare January 30, 2021 19:29
@jonatack jonatack changed the title gui: display plain "Inbound" in peer details Display plain "Inbound" in peer details Jan 30, 2021
@hebasto

hebasto commented Jan 30, 2021

Copy link
Copy Markdown
Member

Alternative version to #201.

Concept ACK, but #201 still preferred to me, tbh.

@maflcko

maflcko commented Jan 31, 2021

Copy link
Copy Markdown
Contributor

ACK 506e658

@jonatack

jonatack commented Feb 5, 2021

Copy link
Copy Markdown
Member Author

-netinfo on master is now aligned with this change:

Screenshot from 2021-02-05 17-14-34

@jonasschnelli jonasschnelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 506e658

@jonasschnelli
jonasschnelli merged commit 6c61408 into bitcoin-core:master Feb 5, 2021
@jonatack
jonatack deleted the display-plain-inbound-and-add-release-notes branch February 5, 2021 17:53
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 5, 2021
506e658 gui: display plain "Inbound" in peer details (Jon Atack)

Pull request description:

  Alternative version to #201.

ACKs for top commit:
  MarcoFalke:
    ACK 506e658
  jonasschnelli:
    utACK 506e658

Tree-SHA512: 88d141b14684c1dcdff47f7ba241e5a7c42c14da3d9aaa89f1649235a64fd26bc5a6055707dc07992cd9d8c05d143754f6dd51ccee69fd4309336dd07c52e61c

@lehuuhieu7777 lehuuhieu7777 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants