Clarify the interaction between BIP62 rule 6 (clean stack) and P2SH - #115
Closed
sipa wants to merge 2 commits into
Closed
Clarify the interaction between BIP62 rule 6 (clean stack) and P2SH#115sipa wants to merge 2 commits into
sipa wants to merge 2 commits into
Conversation
Clarify that BIP62 rule 6 (clean stack) only applies after potential P2SH redeemscript evaluation. Applying it before the redeemscript evaluation means that every P2SH script will fail it, as P2SH by definition uses an unclean stack (to specify the redeemscript inputs).
Member
There was a problem hiding this comment.
IMO this shouldn't apply to all version>=2 transactions - too limiting on future stuff...
Member
Author
luke-jr
pushed a commit
to luke-jr/bips
that referenced
this pull request
Jun 6, 2017
As per discussion in bitcoin#115, we now allow `shutdown` immediately following `commitment_signed`. This means that revoke-and-ack doesn't *always* ack the shutdown. Rather than specify that a revoke-and-ack which is caused by an update-commit following the shutdown acknowledges, we leave this unacknowledged until we actually start closing. This means we will retransmit it on every reconnect until then. But that's not all that wasteful, and fairly robust. Suggested-by: Pierre-Marie Padiou <pm.padiou@gmail.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.