Skip to content

Several updates to BIP62 - #117

Closed
sipa wants to merge 10 commits into
bitcoin:masterfrom
sipa:only3
Closed

Several updates to BIP62#117
sipa wants to merge 10 commits into
bitcoin:masterfrom
sipa:only3

Conversation

@sipa

@sipa sipa commented Nov 5, 2014

Copy link
Copy Markdown
Member

No description provided.

sipa added 2 commits October 26, 2014 00:48
Clarify that BIP62 rule 6 (clean stack) only applies after potential P2SH redeemscript evaluation.
Applying it before the redeemscript evaluation means that every P2SH script will fail it,
as P2SH by definition uses an unclean stack (to specify the redeemscript inputs).
Comment thread bip-0062.mediawiki Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me the permanent rules should be #1 and #3. It's conceivable we may at some point want executable scriptSig content...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not requiring #2: If it's controversial, we should drop the requirement, but I really no reason.
Requiring #3: no. There may be existing P2SH scripts (unknown to the senders) which do a non-compliant push (for example for the multisig counts).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luke-jr I've got a use-case for executable scriptSig content to be able to sign how much fees a tx spends, among many other cases.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And yeah, I think only allowing pushdata ops in P2SH scriptSigs was a mistake.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, removed rule 2 being mandatory.

@sipa

sipa commented Nov 8, 2014

Copy link
Copy Markdown
Member Author

Removed the hashtype requirement (as it's not required for malleability protection, and may be useful otherwise), and added a clarification that even non-evaluated CHECKMULTISIG signatures need to be strict DER (even though the implementation of the opposite is easier, the semantics become more complex to explain). Thanks to @petertodd for pointing that out.

@sipa
sipa force-pushed the only3 branch 2 times, most recently from fd45435 to 5163846 Compare November 9, 2014 11:34
@laanwj

laanwj commented Dec 16, 2014

Copy link
Copy Markdown
Member

Needs rebase

@laanwj

laanwj commented Mar 11, 2015

Copy link
Copy Markdown
Member

Stil needs rebase (or close, if no longer relevant).

@luke-jr luke-jr added the Proposed BIP modification PR by non-owner to update BIP content label Oct 23, 2015
@laanwj

laanwj commented Dec 8, 2015

Copy link
Copy Markdown
Member

Closing this - IIRC BIP62 is retracted

@laanwj laanwj closed this Dec 8, 2015
luke-jr pushed a commit to luke-jr/bips that referenced this pull request Jun 6, 2017
We dropped reference 1 and 2 during the split, and the offset
numbering is causing a bit of head-scratching. This renumbers the
reference.

Closes bitcoin#117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Proposed BIP modification PR by non-owner to update BIP content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants