Skip to content

Update the implementations section of BIP0032. - #293

Closed
jgeewax wants to merge 3 commits into
bitcoin:masterfrom
jgeewax:patch-1
Closed

Update the implementations section of BIP0032.#293
jgeewax wants to merge 3 commits into
bitcoin:masterfrom
jgeewax:patch-1

Conversation

@jgeewax

@jgeewax jgeewax commented Jan 22, 2016

Copy link
Copy Markdown

Mostly cosmetic changes, added bip32-utils (Javascript).

@jonasschnelli

Copy link
Copy Markdown
Contributor

Would you mind adding libbtc (C library)?
https://github.com/libbtc/libbtc

@jgeewax

jgeewax commented Jan 22, 2016

Copy link
Copy Markdown
Author

Updated (and also realized the languages were in random order, so I sorted them).

@jonasschnelli

Copy link
Copy Markdown
Contributor

ACK

@schildbach

Copy link
Copy Markdown
Contributor

Could you perhaps add bitcoinj, one of the earliest implementors of BIP32?

@jgeewax

jgeewax commented Jan 22, 2016

Copy link
Copy Markdown
Author

Done.

@jgeewax

jgeewax commented Jan 22, 2016

Copy link
Copy Markdown
Author

@dcousens : Thanks for the heads up. I actually discovered that today (bip32-utils wasn't actually necessary, just a HD node and .derive())

I'll update accordingly -- thanks for the heads up 👍

@dcousens

Copy link
Copy Markdown
Contributor

@jgeewax no worries :), sorry I accidentally removed my comment. TL;DR for others was that the listed library was actually just a convenience wrapper for bitcoinjs-lib (which is what is now listed).

@afk11

afk11 commented Jan 23, 2016

Copy link
Copy Markdown
Contributor

Since you're at it... Could you update bitcoin-lib-php to bitcoin-php? Same organization, just the repository and link name please!

@jgeewax

jgeewax commented Jan 23, 2016

Copy link
Copy Markdown
Author

@afk11 : Done :)

Comment thread bip-0032.mediawiki Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/nNde.js/node.js/

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that. Fixed.

@luke-jr

luke-jr commented Jan 24, 2016

Copy link
Copy Markdown
Member

@sipa

@luke-jr luke-jr added the Proposed BIP modification PR by non-owner to update BIP content label Jan 24, 2016
Mostly cosmetic changes, added bip32-utils (Javascript).
@sipa

sipa commented Jul 16, 2016

Copy link
Copy Markdown
Member

How is this related to #310?

@afk11

afk11 commented Jul 16, 2016

Copy link
Copy Markdown
Contributor

@sipa they're independent, but both re-format the entire list and carry their own additions :/

@jonathancross

Copy link
Copy Markdown
Contributor

@jgeewax This needs to be rebased / conflicts resolved.

@jgeewax

jgeewax commented Mar 28, 2018

Copy link
Copy Markdown
Author

@jonathancross Fixed (some of it was duplicated info, merged in the new content)

@afk11

afk11 commented Mar 28, 2018

Copy link
Copy Markdown
Contributor

Hey @jgeewax!

From the history it looks like some of the changes were dropped from the PR! Maybe have a look for others - and could you reapply the change from bitcoin-lib-php -> bitcoin-php?

@jgeewax

jgeewax commented Mar 28, 2018

Copy link
Copy Markdown
Author

Gotcha - added a new line for bitcoin-php. Let me know if you notice anything else missing.... Sorry about that.

@kallewoof

Copy link
Copy Markdown
Contributor

Rebase and squash seems to be necessary.

@maflcko

maflcko commented Oct 4, 2021

Copy link
Copy Markdown
Member

Can be closed after 4bc05ff ?

@kallewoof

Copy link
Copy Markdown
Contributor

Thanks for the work @jgeewax. Unfortunately the decision was made to remove the Implementations section, so closing this.

@kallewoof kallewoof closed this Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Proposed BIP modification PR by non-owner to update BIP content

Projects

None yet

Development

Successfully merging this pull request may close these issues.