Add BIP32 bitcoinjs implementation - #310
Conversation
Also formats the list for readability
BIP 32: add BitcoinJS implementation and blockchain.info usage
|
ping @sipa, thoughts? |
|
Per https://bitcoincore.org/en/meetings/2016/05/12/ please link to actual implementation code for BIP32, and not just applications that support it. |
|
@sipa not sure what you mean? The link added was implementation code for BIP32? This was the link added: https://github.com/bitcoinjs/bitcoinjs-lib/blob/v2.1.4/src/hdnode.js
Is the commit hash preferred over the tagged version used above? If so, I'll change it. |
|
I haven't seen commit hashes included much before, just a link to the implementation's file or repo. Re sipa's comment, probably refers to mentioning blockchain.info's use of the bitcoin-js implementation; that information is not typically included in BIP documents. 681c160 There is also another PR (#293) which reformats the BIP32 implementation list, perhaps coordinate so there's only one large update? |
Right! I totally forgot that those commits were included into this. If #293 is just a formatting PR, perfect. Otherwise, I'll submit that independently. |
(1) addressed review items from @rustyrussell and @toadlyBroodle ; and (2) added table of contents courtesy of @bcongdon in bitcoin#310
More line editing and clarifications, also includes typo-fix from @dimitris-t in bitcoin#306 and table of contents from @bcongdon in bitcoin#310.
Also formats the list for readability