You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd prefer to just update to the latest published bdk version ^0.7 which should have all the latest and greatest features. Or ^0.8 will be out soon if there's something you need that's not released yet.
The CI failure is with rust 1.45.
In the BDK repo 1.46 is used instead.
Wouldn't it make sense to use the same versions?
And if so, where can this be adapted?
The reason bdk MSRV (minimum supported rust version) was changed to 1.46 is due to an issue with one of the dependencies (hyper), for more details see bitcoindevkit/bdk#317.
But to be in sync with bdk I don't see a problem incrementing the MSRV for bdk-cli also to 1.46. You just need to update it on line 14 of cont_integration.yml. Nevermind, I see you found it. To allow the merge I also need to update the GitHub "Required" checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adapting to the current master branch of bdk.
After the next release of bdk, Cargo.toml, should go back to use crates.io
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing