[ci] update MSRV to 1.46.0 - #317
Merged
Merged
Conversation
Member
Author
|
If everyone is on board with this change then I'll change the required checks to |
Collaborator
|
ACK |
notmandatory
marked this pull request as draft
March 28, 2021 22:08
Member
Author
|
Moved back to DRAFT until we can get #316 done and a |
Member
|
I would rebase this on #318 and revert the pinning of |
notmandatory
force-pushed
the
ci/update_msrv
branch
from
March 29, 2021 17:53
e8e97da to
0b1fd7f
Compare
Member
Author
|
I also updated the github required checks for |
notmandatory
marked this pull request as ready for review
March 29, 2021 18:05
notmandatory
force-pushed
the
ci/update_msrv
branch
from
March 29, 2021 18:09
0b1fd7f to
dddb999
Compare
notmandatory
force-pushed
the
ci/update_msrv
branch
from
March 29, 2021 18:18
dddb999 to
b226658
Compare
afilini
approved these changes
Mar 30, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change increases BDKs minimum supported rust version to
1.46.0. This will fix a problem with a recently updated version ofhyperwhich breaks our CI build with the current MSRV1.45.0.Notes to the reviewers
Since rust
1.45.0is already five versions back I think it's reasonable to increment it now. Our other option is to pin thehyperversion to0.14.4(see #316) but that change breaks ourcheck-wasmCI job. I don't think we need to go down that rabbit hole since we shouldn't have any users who can't update to at least1.46.0.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing