Skip to content

[ci] update MSRV to 1.46.0 - #317

Merged
afilini merged 1 commit into
bitcoindevkit:masterfrom
notmandatory:ci/update_msrv
Mar 30, 2021
Merged

[ci] update MSRV to 1.46.0#317
afilini merged 1 commit into
bitcoindevkit:masterfrom
notmandatory:ci/update_msrv

Conversation

@notmandatory

@notmandatory notmandatory commented Mar 27, 2021

Copy link
Copy Markdown
Member

Description

This change increases BDKs minimum supported rust version to 1.46.0. This will fix a problem with a recently updated version of hyper which breaks our CI build with the current MSRV 1.45.0.

Notes to the reviewers

Since rust 1.45.0 is already five versions back I think it's reasonable to increment it now. Our other option is to pin the hyper version to 0.14.4 (see #316) but that change breaks our check-wasm CI job. I don't think we need to go down that rabbit hole since we shouldn't have any users who can't update to at least 1.46.0.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory

notmandatory commented Mar 27, 2021

Copy link
Copy Markdown
Member Author

If everyone is on board with this change then I'll change the required checks to 1.46.0 instead of 1.45.0.

@LLFourn

LLFourn commented Mar 28, 2021

Copy link
Copy Markdown
Collaborator

ACK

@notmandatory
notmandatory marked this pull request as draft March 28, 2021 22:08
@notmandatory

Copy link
Copy Markdown
Member Author

Moved back to DRAFT until we can get #316 done and a 0.5.1 release out. Then we can re-evaluate this change for a future release.

@afilini

afilini commented Mar 29, 2021

Copy link
Copy Markdown
Member

I would rebase this on #318 and revert the pinning of hyper as well since it won't be needed on 1.46

@notmandatory

Copy link
Copy Markdown
Member Author

I also updated the github required checks for master branch from 1.45.0 to 1.46.0.

@notmandatory
notmandatory marked this pull request as ready for review March 29, 2021 18:05
@afilini
afilini merged commit b226658 into bitcoindevkit:master Mar 30, 2021
@notmandatory
notmandatory deleted the ci/update_msrv branch March 30, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants