This repository was archived by the owner on Mar 7, 2026. It is now read-only.
Improved BMDA probe scanning#1502
Merged
dragonmux merged 25 commits intoJul 20, 2023
Merged
Conversation
dragonmux
suggested changes
Jun 1, 2023
Member
dragonmux
left a comment
dragonmux
left a comment
There was a problem hiding this comment.
Thank you for the contribution! What a major piece of work, and an awesome thing to get sorted out.
As talked about in DMs, this is only a first pass of review, and we expect to have to do several more as things get ironed out and rationalised.
sidprice
force-pushed
the
feature/improved-bmda-probe-scan
branch
from
090e490 to
ca73e0f
Compare
dragonmux
added
Enhancement
sidprice
force-pushed
the
feature/improved-bmda-probe-scan
branch
2 times, most recently
from
de0f7f1 to
c0c6591
Compare
dragonmux
reviewed
Jun 4, 2023
Member
dragonmux
left a comment
dragonmux
left a comment
There was a problem hiding this comment.
As promised, here's our second review pass - trying to complete review of all FTDI code so we can get into the meat and potatoes of the probe scanning rework next round
sidprice
force-pushed
the
feature/improved-bmda-probe-scan
branch
from
c0c6591 to
310c138
Compare
dragonmux
force-pushed
the
feature/improved-bmda-probe-scan
branch
8 times, most recently
from
dfec127 to
4a7e660
Compare
sidprice
force-pushed
the
feature/improved-bmda-probe-scan
branch
2 times, most recently
from
52a6d35 to
fd16f59
Compare
sidprice
force-pushed
the
feature/improved-bmda-probe-scan
branch
2 times, most recently
from
d2b901b to
616d27f
Compare
dragonmux
previously requested changes
Jul 12, 2023
Member
dragonmux
left a comment
dragonmux
left a comment
There was a problem hiding this comment.
We have done a coarse review of bmp_libusb.c now (sorry it took so long to get to) and we'll do a further review after you've had a chance to work through the points raised in this one.
ALTracer
reviewed
Jul 12, 2023
ALTracer
reviewed
Jul 12, 2023
ALTracer
reviewed
Jul 12, 2023
sidprice
force-pushed
the
feature/improved-bmda-probe-scan
branch
5 times, most recently
from
d4e0c54 to
34f1822
Compare
… and use FTD2xx on Windows
dragonmux
force-pushed
the
feature/improved-bmda-probe-scan
branch
from
65f2562 to
ad5e834
Compare
dragonmux
force-pushed
the
feature/improved-bmda-probe-scan
branch
2 times, most recently
from
3efdc7a to
1e6193b
Compare
…faces during scan
bmp_libusb: Additional commit for STLink V2 serial number fix
bmp_libusb: More scan skipping additions
dragonmux
force-pushed
the
feature/improved-bmda-probe-scan
branch
from
1e6193b to
d8fe188
Compare
sidprice
force-pushed
the
feature/improved-bmda-probe-scan
branch
from
d8fe188 to
b03aac9
Compare
dragonmux
force-pushed
the
feature/improved-bmda-probe-scan
branch
from
b03aac9 to
daecdef
Compare
dragonmux
reviewed
Jul 19, 2023
Member
dragonmux
left a comment
dragonmux
left a comment
There was a problem hiding this comment.
This all looks good to us now, so handing this over to Esden for final review seeing we've touched the files ourself too much.
Contributor
Author
|
@dragonmux Agreed, this was a great team effort! |
esden
approved these changes
Jul 20, 2023
Member
esden
left a comment
esden
left a comment
There was a problem hiding this comment.
This looks great. Thanks for all the hard work. I don't have comments at the moment without spending way too much time stifling progress here. :D I did make a scan over the changes and it is a great improvement over all. Thank you @sidprice and @dragonmux for all the hard work.
This was referenced Jul 20, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a complete rewrite of the BMDA probe scanner and also includes an implementation for FTDI-based probes on Windows. The latter does not require and special driver installation.
make PROBE_HOST=native)make PROBE_HOST=hosted)