This repository was archived by the owner on Mar 7, 2026. It is now read-only.
Fix: BMDA CMSIS-DAP v2 selection#1552
Merged
Merged
Conversation
… in bmp_read_product_version()
… to reduce the nesting complexity
…terfaces and setting the info structure up so the CMSIS-DAP backend opens the proper interface
…when we've been able to list a set of discovered probes
dragonmux
added
Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description
This PR addresses a small regression introduced in #1502 which causes CMSIS-DAP probes to be assumed to be v1 even when they might be v2 or support both.
We fix this by re-checking the descriptors of the probe if it's a CMSIS-DAP probe, once it's been selected by the probe discovery code. We then check for the v2 descriptors and extract the correct endpoints to allow the backend to do the right thing.
The way this is done also ensures that we should always pick up the proper interfaces no matter what order they appear in.
Your checklist for this pull request
make PROBE_HOST=native)make PROBE_HOST=hosted)Closing issues
Fixes #959