fix(acp): advertise protocol version 1 until v2 is fully implemented - #4748
Closed
santhiprakash wants to merge 1 commit into
Closed
fix(acp): advertise protocol version 1 until v2 is fully implemented#4748santhiprakash wants to merge 1 commit into
santhiprakash wants to merge 1 commit into
Conversation
Signed-off-by: Santhi Prakash <b.santhiprakash@gmail.com>
Author
|
Closing this. On a fresh re-read of the current code,
That's a deliberate, documented maintainer decision to advertise v2 early, not an oversight — so this PR is re-litigating a settled stance rather than fixing a drift. The recent #5195 (ACP v2 messageId handling in Thanks for the consideration; happy to reopen if the RFD outcome or adapter-interop evidence makes v1 the right call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buzz-acpwas sendingprotocolVersion: 2in theinitializerequest while still using the v1-shapedclientInfo/clientCapabilitiesbody and consuming v1 response fields (e.g.stopReasoninsession/promptandagentInfo/serverInfoin the initialize result). V2-capable adapters such asagy-acptherefore negotiated v2, validated the request against the v2 schema, and rejected the handshake with-32602because the requiredinfofield was missing.This change reverts the advertised version to
1and updates the inline comment and the unit test to match. Sending a v1 request lets v2-capable adapters downgrade to v1, whichbuzz-acpalready implements end-to-end.Related issue
Fixes #4728.
Testing
cargo test -p buzz-acp— all 668 tests pass.just fmt-checkpasses.cargo clippy -p buzz-acp --all-targets --all-features -- -D warningspasses.The full workspace
just clippy/just cicould not be completed locally because the environment disk was exhausted while compiling the broader workspace after thebuzz-acpverification. CI will run the remaining gates.