Skip to content

fix(acp): advertise protocol version 1 until v2 is fully implemented #4748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
santhiprakash wants to merge 1 commit into from
+9 −5
Closed

fix(acp): advertise protocol version 1 until v2 is fully implemented #4748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions crates/buzz-acp/src/acp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ fn agent_error_from_json(error: &serde_json::Value) -> AcpError {

fn build_initialize_params() -> serde_json::Value {
serde_json::json!({
"protocolVersion": 2,
"protocolVersion": 1,
"clientCapabilities": build_client_capabilities(),
"clientInfo": {
"name": "buzz-acp",
Expand Down Expand Up @@ -596,8 +596,8 @@ impl AcpClient {
/// arm can choose [`ACP_STEER_METHOD`] for adapters that implement it.
/// Parsed here rather than at each call site so no caller can forget it.
pub async fn initialize(&mut self) -> Result<serde_json::Value, AcpError> {
// Requesting version 2 is an intentional temporary pin — we are squatting
// on ACP v2 ahead of the upstream ACP RFD. Revisit when that RFD merges.
// The v2 ACP request/response shape and prompt lifecycle are not yet
// implemented, so request v1 to avoid confusing v2-capable adapters.
let params = build_initialize_params();
let result = self.send_request("initialize", params).await?;
self.steering_supported = result
Expand Down Expand Up @@ -2399,15 +2399,19 @@ mod tests {
"id": 0u64,
"method": "initialize",
"params": {
"protocolVersion": 2,
"protocolVersion": 1,
"clientCapabilities": build_client_capabilities(),
"clientInfo": {
"name": "buzz-acp",
"version": "0.1.0"
}
}
});
assert_eq!(msg["params"]["protocolVersion"].as_u64(), Some(2));
assert_eq!(msg["params"]["protocolVersion"].as_u64(), Some(1));
assert!(
msg["params"].get("info").is_none(),
"v1 initialize params must not include the v2-only `info` field"
);
assert_eq!(
msg["params"]["clientInfo"]["name"].as_str(),
Some("buzz-acp")
Expand Down