refactor: add 'gc lifetime to core gc types - #5446
Merged
Merged
Conversation
github-actions
Bot
added
Waiting On Review
shruti2522
marked this pull request as ready for review
July 23, 2026 23:17
jedel1043
approved these changes
Jul 24, 2026
jedel1043
left a comment
jedel1043
left a comment
Member
There was a problem hiding this comment.
Nice to see the beginnings of the integration with the new Gc!
jedel1043
pushed a commit
that referenced
this pull request
Jul 25, 2026
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel necessary. ---> this is a follow up to the previous PR #5446 that introduced the `'gc` lifetime, we now require a valid `MutationContext` for all gc pointers in boa_gc We must pass it to `Gc::new`, `WeakGc::upgrade`, `Ephemeron` and `WeakMap`, this stops pointers from living longer than they are supposed to. To keep the engine compiling, I added a fake `MutationContext::dummy()` to use as a temporary patch until we pass the real context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding the
'gclifetime to coreboa_gctypes (likeGc,GcErased,WeakMap) to make sure Gc pointers are safely tied to the lifetime of the arena they belong to.to keep this PR small and easy to review, I've used a temporary
'staticlifetime for all theGcpointers. I'll replace these placeholders with the real arena lifetimes in a follow up PR when updating toMutationContext