refactor: add MutationContext for Gc allocations - #5458
Merged
Conversation
github-actions
Bot
added
Waiting On Review
shruti2522
changed the title
github-actions
Bot
removed
the
Waiting On Review
Member
|
Also, on your next PR you might want to enable CI by adding the dev/oscars-gc branch to the CI file |
Contributor
Author
sure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a follow up to the previous PR #5446 that introduced the
'gclifetime, we now require a validMutationContextfor all gc pointers in boa_gcWe must pass it to
Gc::new,WeakGc::upgrade,EphemeronandWeakMap, this stops pointers from living longer than they are supposed to.To keep the engine compiling, I added a fake
MutationContext::dummy()to use as a temporary patch until we pass the real context