chore: sync new models - #834
Conversation
fefb293 to
40df2b1
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Codex (@codex) review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40df2b1d36
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
| "openai.gpt-5.5": ["bedrock"], | ||
| "openai.gpt-5.4": ["bedrock"], | ||
| "nvidia/nemotron-3-ultra-550b-a55b": ["together"], | ||
| "moonshot.kimi-k2-thinking": ["bedrock"], | ||
| "xai.grok-4.3": ["bedrock"], |
There was a problem hiding this comment.
Use a Bedrock-compatible format for these endpoints
These new overrides make getModelEndpointTypes() route openai.gpt-5.5, openai.gpt-5.4, and xai.grok-4.3 to Bedrock, but their catalog specs still have format: "openai"; fetchOpenAI() rejects any Bedrock secret with Bedrock does not support OpenAI format, so requests to any of these newly advertised Bedrock endpoints fail before reaching AWS. Existing Bedrock-only catalog entries use the converse format, or these should not be exposed as Bedrock endpoints until supported.
Useful? React with 👍 / 👎.
40df2b1 to
f6ade0e
Compare
Codex Review ResponsePR: #834 Action taken: Changed
Why: These models have No changes were made to |
f6ade0e to
a804561
Compare
|
Codex (@codex) review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a804561cc8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
| "openai.gpt-5.5": ["bedrock"], | ||
| "openai.gpt-5.4": ["bedrock"], | ||
| "nvidia/nemotron-3-ultra-550b-a55b": ["together"], | ||
| "moonshot.kimi-k2-thinking": ["bedrock"], | ||
| "xai.grok-4.3": ["bedrock"], |
There was a problem hiding this comment.
Don't advertise Bedrock for OpenAI-format specs
These new endpoint entries make getModelEndpointTypes offer Bedrock for openai.gpt-5.5, openai.gpt-5.4, and xai.grok-4.3, but their catalog specs still have format: "openai" in model_list.json. In this proxy, fetchModel dispatches by modelSpec.format, and fetchOpenAI immediately rejects Bedrock secrets with Bedrock does not support OpenAI format, so selecting these newly advertised Bedrock endpoints fails before reaching AWS. Either keep them out of AvailableEndpointTypes or change the Bedrock specs to the Converse format used by the existing Bedrock OpenAI models.
Useful? React with 👍 / 👎.
| "reasoning": true, | ||
| "max_input_tokens": 202800, | ||
| "max_output_tokens": 128000, | ||
| "max_output_tokens": 202800, |
There was a problem hiding this comment.
Keep GLM 5.1 output capped below its context window
This copies the 202.8k context window into max_output_tokens; however GLM-5.1's documented maximum max_tokens is 131072 (see Z.AI's core-parameters table), and the sibling zai-org/GLM-5.1 entry above remains capped at 128000. With this value, clients can accept or default to max_tokens values Fireworks will reject for accounts/fireworks/models/glm-5p1; keep 202800 as the input/context limit and leave the output cap around 128K.
Useful? React with 👍 / 👎.
a804561 to
f07127c
Compare
Codex Review ResponseChanges madeP1: Bedrock models using wrong format (openai.gpt-5.5, openai.gpt-5.4, xai.grok-4.3)Changed
The proxy's No changes to P2: GLM 5.1 max_output_tokens on FireworksChanged |
f07127c to
7849813
Compare
|
Codex (@codex) review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 784981375e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
| "openai.gpt-5.5": ["bedrock"], | ||
| "openai.gpt-5.4": ["bedrock"], | ||
| "nvidia/nemotron-3-ultra-550b-a55b": ["together"], | ||
| "moonshot.kimi-k2-thinking": ["bedrock"], | ||
| "xai.grok-4.3": ["bedrock"], |
There was a problem hiding this comment.
Use a Bedrock-compatible format for these models
When any of these newly exposed Bedrock mappings is selected, the corresponding model specs still declare format: "openai", so fetchModel dispatches into fetchOpenAI() and that path immediately rejects secret.type === "bedrock" with “Bedrock does not support OpenAI format.” In environments where the credentials lookup returns a Bedrock secret (or fallback secret selection uses getModelEndpointTypes), these advertised Bedrock models will fail before reaching Bedrock; either mark them with a Bedrock-supported format/routing path or do not expose them as Bedrock endpoint types yet.
Useful? React with 👍 / 👎.
7849813 to
6094b11
Compare
Codex Review ResponseIssue: Bedrock models with incompatible
|
6094b11 to
6b404c6
Compare
|
Codex (@codex) review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b404c619f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
| "openai.gpt-5.5": ["bedrock"], | ||
| "openai.gpt-5.4": ["bedrock"], | ||
| "nvidia/nemotron-3-ultra-550b-a55b": ["together"], | ||
| "moonshot.kimi-k2-thinking": ["bedrock"], | ||
| "xai.grok-4.3": ["bedrock"], |
There was a problem hiding this comment.
Use a Bedrock-compatible format for these models
In this repo, these newly exposed Bedrock-only IDs are defined in model_list.json with format: "openai", and fetchModel dispatches by that format before considering the provider. When getModelEndpointTypes returns bedrock for these models, a Bedrock secret will be sent to fetchOpenAI, which immediately throws Bedrock does not support OpenAI format in packages/proxy/src/proxy.ts:2130-2131, so requests for these advertised Bedrock models fail before reaching Bedrock; either do not expose them as Bedrock here or give them a Bedrock-supported format/path.
Useful? React with 👍 / 👎.
6b404c6 to
3ab5c4c
Compare
Codex Review ResponseIssue: Bedrock-only models with
|
…rmat to converse
Both model-sync workflows have a 'Respond to Codex review with Claude Code'
step that auto-applies Codex's suggestions to the catalog. When the index.ts
Bedrock mappings for openai.gpt-5.5 / openai.gpt-5.4 / xai.grok-4.3 are present,
Codex posts a P1 ('openai format on a Bedrock model fails') because the TS
proxy's fetchOpenAI rejects Bedrock secrets, and the auto-apply step 'fixes' it
by flipping format openai->converse. That is wrong: these are Bedrock Mantle
models served only via the OpenAI-compatible bedrock-mantle endpoint, which does
not support the Converse API or InvokeModel, so converse breaks invocation at
AWS. This recurred across #834/#836/#840/#843 (all reverting the validated #822
openai fix). The LiteLLM field sync never touches format (no checkAndUpdateFormat),
so this guardrail on the codex-response prompt is the correct lever.
Adds a 'Bedrock Mantle exception' instruction to the codex-response prompt in
both sync-models.yaml and fix-missing-model-bot-issues.yaml: keep format=openai
for bedrock-only openai-format models and explain in the summary that this is an
intentional Mantle case to be handled proxy-side, not a catalog change.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Automated sync of model metadata and newly available models from the approved provider allowlist.