chore: update model catalog from bot issues - #840
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Codex (@codex) review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 204f1a644d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
| "openai.gpt-5.5": ["bedrock"], | ||
| "openai.gpt-5.4": ["bedrock"], | ||
| "nvidia/nemotron-3-ultra-550b-a55b": ["together"], | ||
| "moonshot.kimi-k2-thinking": ["bedrock"], | ||
| "xai.grok-4.3": ["bedrock"], |
There was a problem hiding this comment.
Don't advertise Bedrock for OpenAI-format specs
When a request uses one of these newly mapped Bedrock-only models, getModelEndpointTypes now selects a Bedrock secret, but the catalog entries for openai.gpt-5.5, openai.gpt-5.4, and xai.grok-4.3 still declare format: "openai". That path enters fetchOpenAI, which explicitly rejects secret.type === "bedrock", so these models will always fail through the only provider advertised here unless they are routed through a supported Bedrock/Converse format or not exposed as Bedrock yet.
Useful? React with 👍 / 👎.
204f1a6 to
a13ed5f
Compare
Codex Review ResponseIssue: Bedrock-only models with
|
…rmat to converse
Both model-sync workflows have a 'Respond to Codex review with Claude Code'
step that auto-applies Codex's suggestions to the catalog. When the index.ts
Bedrock mappings for openai.gpt-5.5 / openai.gpt-5.4 / xai.grok-4.3 are present,
Codex posts a P1 ('openai format on a Bedrock model fails') because the TS
proxy's fetchOpenAI rejects Bedrock secrets, and the auto-apply step 'fixes' it
by flipping format openai->converse. That is wrong: these are Bedrock Mantle
models served only via the OpenAI-compatible bedrock-mantle endpoint, which does
not support the Converse API or InvokeModel, so converse breaks invocation at
AWS. This recurred across #834/#836/#840/#843 (all reverting the validated #822
openai fix). The LiteLLM field sync never touches format (no checkAndUpdateFormat),
so this guardrail on the codex-response prompt is the correct lever.
Adds a 'Bedrock Mantle exception' instruction to the codex-response prompt in
both sync-models.yaml and fix-missing-model-bot-issues.yaml: keep format=openai
for bedrock-only openai-format models and explain in the summary that this is an
intentional Mantle case to be handled proxy-side, not a catalog change.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Automated daily batch of model catalog updates from bot issues.
Included issues
Summary
gpt-5.5-progpt-5.5-pro-2026-04-23gpt-5.4-progpt-5.4-pro-2026-03-05gpt-5.5-progpt-5.5-pro-2026-04-23gpt-5.4-progpt-5.4-pro-2026-03-05gpt-4o-2024-05-13o1-2024-12-17o4-mini-2025-04-16gpt-4o-2024-05-13o1-2024-12-17o4-mini-2025-04-16gpt-5-2025-08-07o3-2025-04-16gpt-5-mini-2025-08-07gpt-5-2025-08-07o3-2025-04-16gpt-5-mini-2025-08-07Verified metadata
#837: [BOT ISSUE] OpenAI: remove incorrect cached input pricing from gpt-5.5-pro and gpt-5.4-pro
Verification notes
Verification
sync_models vs proposed update
sync_models cross-check found differences. Official provider verification was used for the applied values, and sync_models discrepancies are listed below for review.
#838: [BOT ISSUE] OpenAI: add deprecation_date for gpt-4o-2024-05-13, o1-2024-12-17, o4-mini-2025-04-16
Verification notes
Verification
sync_models vs proposed update
sync_models cross-check found differences. Official provider verification was used for the applied values, and sync_models discrepancies are listed below for review.
#839: [BOT ISSUE] OpenAI: add deprecation_date for gpt-5-2025-08-07, o3-2025-04-16, gpt-5-mini-2025-08-07
Verification notes
Verification
sync_models vs proposed update
sync_models cross-check found differences. Official provider verification was used for the applied values, and sync_models discrepancies are listed below for review.