Fix listeners leak in cmd.js#155
Closed
janm6k wants to merge 1 commit intobrowserify:masterfrom
janm6k:cmd-fix-listeners-leak
Closed
Fix listeners leak in cmd.js#155janm6k wants to merge 1 commit intobrowserify:masterfrom janm6k:cmd-fix-listeners-leak
janm6k wants to merge 1 commit intobrowserify:masterfrom
janm6k:cmd-fix-listeners-leak
Conversation
Each call of `bundle` function registered new listeners, while keeping the old one registered.
Member
|
Thanks @janm6k, but it'll still leak if there is an error since in that case |
This was referenced Mar 25, 2015
Member
|
This was fixed in #167. Thanks for the contribution though! |
Author
|
Yup, your solution looks better. Thanks for fixing it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each call of
bundlefunction registered new listeners to getbytesandtime, and it never removed them.