Don't re-add "bytes" and "time" listeners on rebundle#167
Merged
1 commit merged intomasterfrom Mar 25, 2015
Merged
Conversation
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
bytesandtimelisteners are getting re-added on every re-bundle. #155 proposes to fix this by adding the listeners withonceinstead ofon. This works for cases when the build was successful, but if there was a build error, those handlers will never fire, thus never get unbound. To account for that would require that we hold references to listener functions and callremoveListenerwith them if an error occurs - but that's too much.It's easier to just bind the events one time when the browserify instance is created. This might lead to inconsistent log output if there is a race between concurrent rebuilds - but that's highly unlikely.
cc: @substack