Fix Kythe workflow for Bazel 8+: load proto_lang_toolchain from rules…#11366
Merged
dan-stowell merged 1 commit intomasterfrom Feb 20, 2026
Merged
Fix Kythe workflow for Bazel 8+: load proto_lang_toolchain from rules…#11366dan-stowell merged 1 commit intomasterfrom
dan-stowell merged 1 commit intomasterfrom
Conversation
tylerwilliams
approved these changes
Feb 20, 2026
fmeum
reviewed
Feb 20, 2026
dan-stowell
force-pushed
the
bbdan-fix-kythe
branch
from
0d351c0 to
143a2cc
Compare
…_proto Bazel 8+ removed proto_lang_toolchain as a native rule, breaking the Kythe release BUILD file which uses it without a load() statement. This caused the entire Kythe package to fail to load, making all extract_kzip_* action listeners unavailable and failing analysis on every target in the build. Patch the Kythe BUILD file at checkout time to add the required load() statement, and ensure the Kythe MODULE.bazel declares rules_proto as a dependency for the local_path_override code path. TODO: Update the BUILD and MODULE.bazel in https://github.com/buildbuddy-io/kythe, cut a new release, and update kytheDownloadURL in config.go so this runtime patching is no longer needed. Co-authored-by: Shelley <shelley@exe.dev>
dan-stowell
force-pushed
the
bbdan-fix-kythe
branch
from
143a2cc to
24c88d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…_proto
Bazel 8+ removed proto_lang_toolchain as a native rule, breaking the Kythe release BUILD file which uses it without a load() statement. This caused the entire Kythe package to fail to load, making all extract_kzip_* action listeners unavailable and failing analysis on every target in the build.
Patch the Kythe BUILD file at checkout time to add the required load() statement, and ensure the Kythe MODULE.bazel declares rules_proto as a dependency for the local_path_override code path.
TODO: Update the BUILD and MODULE.bazel in https://github.com/buildbuddy-io/kythe, cut a new release, and update kytheDownloadURL in config.go so this runtime patching is no longer needed.