feat: Fetcher updates #1090
fix copilot comments
- Loading branch information
commit a9e94696aa2a7d7ad47ad906b1d11cd376e6648b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,12 +45,16 @@ export default function useWorkflowHistoryFetcher( | |
|
|
||
| useEffect(() => { | ||
| if (!fetcherRef.current) return; | ||
| let lastFlattenedPagesCount: number = 0; | ||
| const unsubscribe = fetcherRef.current.onChange((state) => { | ||
| const pagesCount = state.data?.pages?.length || 0; | ||
| // if the pages count is greater than the last flattened pages count, then we need to flatten the pages and call the onEventsChange callback | ||
| if (pagesCount > lastFlattenedPagesCount) { | ||
| lastFlattenedPagesCount = pagesCount; | ||
| onEventsChange( | ||
| state.data?.pages?.flatMap((page) => page.history?.events || []) || [] | ||
| ); | ||
| } | ||
|
Comment on lines
+53
to
+58
Member
There was a problem hiding this comment. I must be missing something. My understanding:
I would have expected:
I'm a bit confused why we don't pass The hook, as currently implemented, knows too much about the fetcher internals.
Contributor
Author
There was a problem hiding this comment. Not sure if this is a follow up question on this or the message didn't show up for you as it was outdated. We can continue the discussion there. |
||
| // immediately set if there is the first page without throttling other wise throttle | ||
| const executeImmediately = pagesCount <= 1; | ||
| setHistoryQuery(() => state, executeImmediately); | ||
|
|
@@ -62,8 +66,6 @@ export default function useWorkflowHistoryFetcher( | |
| }, [setHistoryQuery, onEventsChange]); | ||
|
|
||
| useEffect(() => { | ||
| return () => { | ||
| fetcherRef.current?.destroy(); | ||
| }; | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I follow.
It sounds like
historyQueryis throttled.On the other hand, the unthrottled flow is...
onChange, then getstate.stateand flatten it (for what purpose?)onEventsChange(why?)I'm probably missing something obvious with grouping in the history page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, history queue is throttled. Since it seems hard to understand this pattern i moved
lastFlattenedPagesCountto be arefoutside the component.The reason why we flatten is that
Pagesis areact-queryconstruct. But helpers and other components accepts arrays of events. It made sense to send events here since the method name isonEventsChange. If we didn't do in this hook we would need to do it in the parent.