Skip to content

feat: Fetcher updates #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Assem-Uber merged 15 commits into from
Nov 21, 2025
Merged

feat: Fetcher updates #1090

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
cc38cb1
fetcher updates
Assem-Uber Nov 20, 2025
2a41fc6
add placeholder for fetcher
Assem-Uber Nov 20, 2025
1f54d95
update fetcher mock
Assem-Uber Nov 20, 2025
3398d8a
fetcher start update
Assem-Uber Nov 20, 2025
fb1f87c
update todo
Assem-Uber Nov 20, 2025
650a918
Apply suggestion from @Copilot
Assem-Uber Nov 20, 2025
a9e9469
fix copilot comments
Assem-Uber Nov 20, 2025
8dcf01c
remove extra comment
Assem-Uber Nov 20, 2025
573c195
lint fix
Assem-Uber Nov 20, 2025
7306663
change lastFlattented initial value to -1
Assem-Uber Nov 20, 2025
e0a327a
Merge branch 'master' into feature/16026/fetcher-updates
Assem-Uber Nov 20, 2025
73e9bd8
move lastFlattenedPagesCount to a ref and remove shouldContinue condi…
Assem-Uber Nov 20, 2025
f8e080d
fix typo and add mock for configs
Assem-Uber Nov 21, 2025
d9da99f
update page size test case
Assem-Uber Nov 21, 2025
04ed13a
Merge branch 'master' into feature/16026/fetcher-updates
Assem-Uber Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update page size test case
  • Loading branch information
@Assem-Uber
Assem-Uber committed Nov 21, 2025
commit d9da99f53712f1ef6b255c903c69043d4819232d
8 changes: 3 additions & 5 deletions src/views/workflow-history/helpers/__tests__/workflow-history-fetcher.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,24 +283,22 @@ describe(WorkflowHistoryFetcher.name, () => {
});

const pageSizes = getCapturedPageSizes();
expect(pageSizes).toHaveLength(1);
expect(pageSizes[0]).toBe('200');
Comment on lines +285 to +286
Copy link
Member

@macrotim macrotim Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to assert behavior of setup and mockEndpoints rather than the "unit under test".

Is this intended?

Copy link
Contributor Author

@Assem-Uber Assem-Uber Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which part exactly is testing the setup method?

What the test does here is capturing what request msw received and make sure that the first request had a query param of 200. The query for rest APIs are sent from the fetcher but received and captured by the setup method.

Copy link
Member

@macrotim macrotim Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like your intent is to introspect the inner workings of the fetcher?

To suggest an alternative approach:

  • Let's generalize it beyond pageSize.
  • Unit tests need to assert correct internal behavior.
  • And asserting the outcome falls short.
  • One solution: The fetcher returns an introspection object.
  • Example: Return debugInfo which provides detailed insights.

I suggest this because the purpose of CapturedPageSizes wasn't immediately clear.

});

it('should use WORKFLOW_HISTORY_PAGE_SIZE_CONFIG for subsequent pages', async () => {
const { fetcher, getCapturedPageSizes } = setup(queryClient);

fetcher.start((state) => (state.data?.pages.length || 0) < 2);
fetcher.start((state) => (state.data?.pages.length || 0) < 3);

await waitFor(() => {
const state = fetcher.getCurrentState();
expect(state.data?.pages).toHaveLength(2);
expect(state.data?.pages).toHaveLength(3);
});

const pageSizes = getCapturedPageSizes();
expect(pageSizes.length).toBeGreaterThanOrEqual(2);
expect(pageSizes[0]).toBe('200');
expect(pageSizes[1]).toBe('1000');
expect(pageSizes[2]).toBe('1000');
});
});

Expand Down