refactor: clean up WorkflowHistoryFetcher code#1121
Merged
adhityamamallan merged 4 commits intocadence-workflow:masterfrom Dec 17, 2025
Merged
Conversation
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the WorkflowHistoryFetcher class to improve code organization and maintainability. The changes are purely structural with no functional changes to behavior.
- Adds comprehensive JSDoc documentation to all public methods
- Removes unused
isStartedinstance variable - Extracts common query enabling logic into a private
enableQuery()method - Extracts state change handling logic into a factory method
createStateChangeHandler()for better separation of concerns
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
macrotim
approved these changes
Dec 17, 2025
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enableQuery()private method to share codecreateStateChangeHandler()private method to improve readability and separate concernsTest plan
Unit tests passing + ran locally to sanity-check.