Skip to content

refactor: clean up WorkflowHistoryFetcher code #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adhityamamallan merged 4 commits into from
Dec 17, 2025
Merged

refactor: clean up WorkflowHistoryFetcher code #1121

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0dc2690
Refactor history fetcher code
adhityamamallan Dec 17, 2025
d515ead
some more changes
adhityamamallan Dec 17, 2025
c93cfaf
remove redundant comments
adhityamamallan Dec 17, 2025
efba02a
Remove reference to throttler
adhityamamallan Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove redundant comments 
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
  • Loading branch information
@adhityamamallan
adhityamamallan committed Dec 17, 2025
commit c93cfaf383dbdb3bd2ae529f3eb753fb593ab1ca
2 changes: 0 additions & 2 deletions src/views/workflow-history/helpers/workflow-history-fetcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,6 @@ export default class WorkflowHistoryFetcher {
*/
fetchSingleNextPage(): void {
const state = this.getCurrentState();
// If the query is still pending, enable it to fetch the first page.
// Otherwise, fetch the next page if it is not already fetching and there are more pages.
if (state.status === 'pending') {
this.enableQuery();
} else if (!state.isFetchingNextPage && state.hasNextPage)
Expand Down