Skip to content

feat: Workflow History V2 - show Failed and Pending events in nav bar#1128

Merged
adhityamamallan merged 11 commits intocadence-workflow:masterfrom
adhityamamallan:navbar-failed-events
Jan 15, 2026
Merged

feat: Workflow History V2 - show Failed and Pending events in nav bar#1128
adhityamamallan merged 11 commits intocadence-workflow:masterfrom
adhityamamallan:navbar-failed-events

Conversation

@adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Jan 5, 2026

Summary

  • Create WorkflowHistoryNavigationBarEventsMenu to show list of events (paginated if >10)
  • Use the events menu component in the nav bar to show failed and pending events
  • Filter out failed and pending events in WorkflowHistoryV2 to pass to nav bar
  • Use React state to handle scrolling to events in both grouped & ungrouped views

Test plan

Unit tests + ran locally.

Screen.Recording.2026-01-05.at.14.55.40.mov
Screenshot 2026-01-05 at 16 03 47 Screenshot 2026-01-05 at 16 03 53

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a navigation bar feature to display failed and pending workflow history events. Users can now quickly identify and navigate to failed or pending events through dedicated buttons in the navigation bar, with support for pagination when there are many events.

  • Refactored event filtering logic to separate sorting from filtering for better reusability
  • Added failed and pending events menu with pagination support
  • Implemented scroll-to-event functionality that automatically clears filters and expands target events

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/views/workflow-history-v2/workflow-history-v2.types.ts Adds EventGroupEntry type alias for cleaner type definitions
src/views/workflow-history-v2/workflow-history-v2.tsx Refactors filtering logic, adds scroll-to-event functionality, and integrates failed/pending event menu items
src/views/workflow-history-v2/workflow-history-navigation-bar/workflow-history-navigation-bar.types.ts Extends navigation bar props to support failed/pending events menus
src/views/workflow-history-v2/workflow-history-navigation-bar/workflow-history-navigation-bar.tsx Adds failed and pending events buttons with menu integration
src/views/workflow-history-v2/workflow-history-navigation-bar/workflow-history-navigation-bar.styles.ts Adds button styles with distinctive background colors for failed (negative) and pending (accent) events
src/views/workflow-history-v2/workflow-history-navigation-bar/__tests__/workflow-history-navigation-bar.test.tsx Adds comprehensive tests for new failed/pending events button rendering
src/views/workflow-history-v2/workflow-history-navigation-bar-events-menu/workflow-history-navigation-bar-events-menu.types.ts Defines types for the events menu component and menu items
src/views/workflow-history-v2/workflow-history-navigation-bar-events-menu/workflow-history-navigation-bar-events-menu.tsx Implements paginated popover menu for displaying event lists
src/views/workflow-history-v2/workflow-history-navigation-bar-events-menu/workflow-history-navigation-bar-events-menu.styles.ts Styles for the menu container, items, and pagination
src/views/workflow-history-v2/workflow-history-navigation-bar-events-menu/workflow-history-navigation-bar-events-menu.constants.ts Defines constant for items per page (10)
src/views/workflow-history-v2/workflow-history-navigation-bar-events-menu/__tests__/workflow-history-navigation-bar-events-menu.test.tsx Comprehensive tests for menu behavior, pagination, and event clicking
src/views/workflow-history-v2/helpers/get-navigation-bar-events-menu-items.ts Helper function to extract menu items from event groups with filtering
src/views/workflow-history-v2/helpers/__tests__/get-navigation-bar-events-menu-items.test.ts Tests for menu item extraction logic
src/views/workflow-history-v2/config/workflow-history-clear-scroll-event-timeout-ms.config.ts Configures 3-second timeout for clearing scroll target state
src/views/workflow-history-v2/__tests__/workflow-history-v2.test.tsx Integration tests for failed/pending events menu items passing to navigation bar

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adhityamamallan adhityamamallan changed the title feat: Navbar failed events feat: Workflow History V2 - show Failed and Pending events in nav bar Jan 5, 2026
@adhityamamallan adhityamamallan marked this pull request as ready for review January 5, 2026 15:06
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
@adhityamamallan adhityamamallan merged commit 5f45bfb into cadence-workflow:master Jan 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants