feat: Workflow History V2 - show Failed and Pending events in nav bar#1128
Merged
adhityamamallan merged 11 commits intocadence-workflow:masterfrom Jan 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a navigation bar feature to display failed and pending workflow history events. Users can now quickly identify and navigate to failed or pending events through dedicated buttons in the navigation bar, with support for pagination when there are many events.
- Refactored event filtering logic to separate sorting from filtering for better reusability
- Added failed and pending events menu with pagination support
- Implemented scroll-to-event functionality that automatically clears filters and expands target events
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/views/workflow-history-v2/workflow-history-v2.types.ts |
Adds EventGroupEntry type alias for cleaner type definitions |
src/views/workflow-history-v2/workflow-history-v2.tsx |
Refactors filtering logic, adds scroll-to-event functionality, and integrates failed/pending event menu items |
src/views/workflow-history-v2/workflow-history-navigation-bar/workflow-history-navigation-bar.types.ts |
Extends navigation bar props to support failed/pending events menus |
src/views/workflow-history-v2/workflow-history-navigation-bar/workflow-history-navigation-bar.tsx |
Adds failed and pending events buttons with menu integration |
src/views/workflow-history-v2/workflow-history-navigation-bar/workflow-history-navigation-bar.styles.ts |
Adds button styles with distinctive background colors for failed (negative) and pending (accent) events |
src/views/workflow-history-v2/workflow-history-navigation-bar/__tests__/workflow-history-navigation-bar.test.tsx |
Adds comprehensive tests for new failed/pending events button rendering |
src/views/workflow-history-v2/workflow-history-navigation-bar-events-menu/workflow-history-navigation-bar-events-menu.types.ts |
Defines types for the events menu component and menu items |
src/views/workflow-history-v2/workflow-history-navigation-bar-events-menu/workflow-history-navigation-bar-events-menu.tsx |
Implements paginated popover menu for displaying event lists |
src/views/workflow-history-v2/workflow-history-navigation-bar-events-menu/workflow-history-navigation-bar-events-menu.styles.ts |
Styles for the menu container, items, and pagination |
src/views/workflow-history-v2/workflow-history-navigation-bar-events-menu/workflow-history-navigation-bar-events-menu.constants.ts |
Defines constant for items per page (10) |
src/views/workflow-history-v2/workflow-history-navigation-bar-events-menu/__tests__/workflow-history-navigation-bar-events-menu.test.tsx |
Comprehensive tests for menu behavior, pagination, and event clicking |
src/views/workflow-history-v2/helpers/get-navigation-bar-events-menu-items.ts |
Helper function to extract menu items from event groups with filtering |
src/views/workflow-history-v2/helpers/__tests__/get-navigation-bar-events-menu-items.test.ts |
Tests for menu item extraction logic |
src/views/workflow-history-v2/config/workflow-history-clear-scroll-event-timeout-ms.config.ts |
Configures 3-second timeout for clearing scroll target state |
src/views/workflow-history-v2/__tests__/workflow-history-v2.test.tsx |
Integration tests for failed/pending events menu items passing to navigation bar |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../workflow-history-navigation-bar-events-menu/workflow-history-navigation-bar-events-menu.tsx
Show resolved
Hide resolved
...low-history-navigation-bar-events-menu/workflow-history-navigation-bar-events-menu.styles.ts
Outdated
Show resolved
Hide resolved
...iews/workflow-history-v2/workflow-history-navigation-bar/workflow-history-navigation-bar.tsx
Outdated
Show resolved
Hide resolved
macrotim
reviewed
Jan 8, 2026
src/views/workflow-history-v2/__tests__/workflow-history-v2.test.tsx
Outdated
Show resolved
Hide resolved
src/views/workflow-history-v2/helpers/__tests__/get-navigation-bar-events-menu-items.test.ts
Outdated
Show resolved
Hide resolved
src/views/workflow-history-v2/helpers/__tests__/get-navigation-bar-events-menu-items.test.ts
Outdated
Show resolved
Hide resolved
Assem-Uber
requested changes
Jan 14, 2026
d06a434 to
240a627
Compare
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
1d7d953 to
2823aaa
Compare
Assem-Uber
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Unit tests + ran locally.
Screen.Recording.2026-01-05.at.14.55.40.mov