Skip to content

feat: Workflow History V2 - show Failed and Pending events in nav bar #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adhityamamallan merged 11 commits into from
Jan 15, 2026
Merged

feat: Workflow History V2 - show Failed and Pending events in nav bar #1128

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d931f2c
initial implementation of scroll to event
adhityamamallan Jan 2, 2026
a53c0ec
more changes
adhityamamallan Jan 2, 2026
480b302
add tests
adhityamamallan Jan 5, 2026
805b287
add tests for nav bar helper
adhityamamallan Jan 5, 2026
f141b7f
Add icon for pending events
adhityamamallan Jan 5, 2026
b8ec93e
address comments
adhityamamallan Jan 5, 2026
cff40e6
Address comments
adhityamamallan Jan 9, 2026
81977bb
rearrange function calls in test
adhityamamallan Jan 9, 2026
35f55f7
Remove 0 timeout from onClickNavMenuEvent
adhityamamallan Jan 14, 2026
e90f8a2
hardcode scroll clear
adhityamamallan Jan 14, 2026
2823aaa
decouple event finding from scrolling
adhityamamallan Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rearrange function calls in test 
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
  • Loading branch information
@adhityamamallan
adhityamamallan committed Jan 14, 2026
commit 81977bbc02edbfa2225117a7455653cc9eb8994d
17 changes: 5 additions & 12 deletions src/views/workflow-history-v2/helpers/__tests__/get-navigation-bar-events-menu-items.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,13 @@ jest.mock(
describe(getNavigationBarEventsMenuItems.name, () => {
it('should return an empty array when eventGroupsEntries is empty', () => {
const eventGroupsEntries: Array<EventGroupEntry> = [];
const filterFn = jest.fn(() => true);

const result = getNavigationBarEventsMenuItems(
eventGroupsEntries,
filterFn
() => true
);

expect(result).toEqual([]);
expect(filterFn).not.toHaveBeenCalled();
});

it('should skip groups with no events', () => {
Expand All @@ -39,15 +37,13 @@ describe(getNavigationBarEventsMenuItems.name, () => {
const eventGroupsEntries: Array<EventGroupEntry> = [
['group1', groupWithoutEvents],
];
const filterFn = jest.fn(() => true);

const result = getNavigationBarEventsMenuItems(
eventGroupsEntries,
filterFn
() => true
);

expect(result).toEqual([]);
expect(filterFn).not.toHaveBeenCalled();
});

it('should skip groups filtered out by filterFn', () => {
Expand Down Expand Up @@ -77,11 +73,10 @@ describe(getNavigationBarEventsMenuItems.name, () => {
['group1', mockActivityEventGroup],
['group2', mockDecisionEventGroup],
];
const filterFn = jest.fn(() => true);

const result = getNavigationBarEventsMenuItems(
eventGroupsEntries,
filterFn
() => true
);

expect(result).toHaveLength(2);
Expand Down Expand Up @@ -111,11 +106,10 @@ describe(getNavigationBarEventsMenuItems.name, () => {
['group1', groupWithShortLabel],
['group2', groupWithoutShortLabel],
];
const filterFn = jest.fn(() => true);

const result = getNavigationBarEventsMenuItems(
eventGroupsEntries,
filterFn
() => true
);

expect(result).toHaveLength(2);
Expand All @@ -127,11 +121,10 @@ describe(getNavigationBarEventsMenuItems.name, () => {
const eventGroupsEntries: Array<EventGroupEntry> = [
['group1', mockActivityEventGroup],
];
const filterFn = jest.fn(() => true);

const result = getNavigationBarEventsMenuItems(
eventGroupsEntries,
filterFn
() => true
);

expect(result).toHaveLength(1);
Expand Down