Skip to content

[WIP] refactor: use C libcbor instead of msgpack cbor#88

Closed
grzuy wants to merge 3 commits into
masterfrom
libcbor
Closed

[WIP] refactor: use C libcbor instead of msgpack cbor#88
grzuy wants to merge 3 commits into
masterfrom
libcbor

Conversation

@grzuy

@grzuy grzuy commented Oct 9, 2018

Copy link
Copy Markdown
Contributor

Closes #63

Blocked by PJK/libcbor-ruby#6

  • Fix tests
  • Update docs with new system lib prerequisite

Related cedarcode/cose-ruby#43

@grzuy

grzuy commented Jan 22, 2019

Copy link
Copy Markdown
Contributor Author

FWIW, some (if not all) issues we're seeing in this PR are related to PJK/libcbor-ruby#5.

@bdewater

Copy link
Copy Markdown
Contributor

One concern I have here is that having to install libcbor separately is not great. It breaks the "just run bundle install and you're done" workflow we have now.

It would be nice if we can package the library with the gem or provide pre-installed binaries like https://github.com/cowboyd/libv8

@grzuy

grzuy commented Jul 2, 2019

Copy link
Copy Markdown
Contributor Author

Yes, I agree it is not ideal to add a sys level dependency.

It would be interesting to explore that possibility of packaging or providing binaries. If we do that, I'd consider first proposing that change to the libcbor gem. That's really were the dependency is coming from.

@grzuy

grzuy commented Nov 27, 2019

Copy link
Copy Markdown
Contributor Author

Closing for now.
Same reason as in cedarcode/cose-ruby#43 (comment).

@grzuy grzuy closed this Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CBOR library choice

2 participants