Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Minor release for Azure Exporter#699

Closed
lzchen wants to merge 9 commits intocensus-instrumentation:v0.6.xfrom
lzchen:v0.6.x
Closed

Minor release for Azure Exporter#699
lzchen wants to merge 9 commits intocensus-instrumentation:v0.6.xfrom
lzchen:v0.6.x

Conversation

@lzchen
Copy link
Copy Markdown
Contributor

@lzchen lzchen commented Jun 28, 2019

The PR as of 07/03/19 merges the current master branch into v0.6.x.
The changelog/versions are changed from 0.x.xdev to the release versions.
Changelog/version in Azure are bumped to the release version (0.3.1)
Django will be done in a different PR.

@lzchen lzchen requested review from a team, c24t, reyang and songy23 as code owners June 28, 2019 21:48
Copy link
Copy Markdown
Contributor

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're missing some *.py files in this PR, with the current PR, the only thing released would be the change log and version.

Copy link
Copy Markdown
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to merge this into the release branch and update the required versions in setup files to get this packaged and released, see #670 and #631 for recent examples. @reyang may be able to help with packaging this.

## Unreleased

## 0.2.2
Released 2019-06-28
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to the date the package is released on PyPI.

# limitations under the License.

__version__ = '0.2.1'
__version__ = '0.2.2'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Micro version updates are usually small and backwards-compatible, this looks like at least a minor-level change to me. https://www.python.org/dev/peps/pep-0440/#semantic-versioning.

# limitations under the License.

__version__ = '0.3.1'
__version__ = '0.3.2'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why put these in the same PR?

@googlebot
Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jul 3, 2019
@lzchen lzchen changed the title Minor release for Azure Exporter and Django Minor release for Azure Exporter Jul 3, 2019
@lzchen
Copy link
Copy Markdown
Contributor Author

lzchen commented Jul 3, 2019

The PR as of now merges the current master branch into v0.6.x.
The changelog/versions are changed from 0.x.xdev to the release versions.
Changelog/version in Azure are bumped to the release version (0.3.1)
Django will be done in a different PR.

Copy link
Copy Markdown
Contributor

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lzchen
Copy link
Copy Markdown
Contributor Author

lzchen commented Jul 16, 2019

@reyang Are you able to sign the CLA or does @c24t have to add the label?

@reyang
Copy link
Copy Markdown
Contributor

reyang commented Jul 16, 2019

@reyang Are you able to sign the CLA or does @c24t have to add the label?

I don't have access to unblock Google CLA. My suggestion is that instead of cherry picking commits, just taking the file changes.

@songy23 songy23 added cla: yes and removed cla: no labels Jul 16, 2019
@googlebot
Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@songy23
Copy link
Copy Markdown
Contributor

songy23 commented Jul 16, 2019

The base branch has an unnecessary rule:

The base branch requires all commits to be signed.

It prevents one user cherry-picking a commit from another user. If we can disable it, this PR should be good to merge.

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@lzchen
Copy link
Copy Markdown
Contributor Author

lzchen commented Jul 17, 2019

@songy23 Good to know. I removed the outstanding commit and applied them manually myself. Should be good to merge.

@lzchen lzchen mentioned this pull request Jul 19, 2019
@lzchen lzchen closed this Jul 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants