Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Azure release#723

Merged
c24t merged 1 commit intocensus-instrumentation:v0.6.xfrom
lzchen:azure-release
Jul 24, 2019
Merged

Azure release#723
c24t merged 1 commit intocensus-instrumentation:v0.6.xfrom
lzchen:azure-release

Conversation

@lzchen
Copy link
Copy Markdown
Contributor

@lzchen lzchen commented Jul 19, 2019

Cont. from [#699]

@lzchen lzchen requested review from a team, c24t, reyang and songy23 as code owners July 19, 2019 23:11
@lzchen
Copy link
Copy Markdown
Contributor Author

lzchen commented Jul 19, 2019

image
Getting merge failure when attempting to merge [#699], attempting to fix.

text
)
return
# Check for non-tryable result
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

‘non-retryable’

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

Add skeleton metrics exporter to azure

add bracket (census-instrumentation#690)

Implement Azure Metrics Exporter (census-instrumentation#693)

fix rst doc for Azure exporter

bump version

fix comment
@lzchen
Copy link
Copy Markdown
Contributor Author

lzchen commented Jul 23, 2019

@c24t @songy23 Can one of you attempt to merge this PR? @reyang is getting a merge failed error when he attempts to do it.

If it still fails, can we disable the branch signature requirement temporarily for this merge?

@songy23
Copy link
Copy Markdown
Contributor

songy23 commented Jul 23, 2019

Will do, PR checks look all good to me though:

Screen Shot 2019-07-23 at 3 29 04 PM

@songy23
Copy link
Copy Markdown
Contributor

songy23 commented Jul 23, 2019

OK now I see the failure:
Screen Shot 2019-07-23 at 3 30 59 PM

I think this has something to do with the branch protection rule since I haven't seen similar issue when merging to master. @c24t can you disable the signature check on v0.6.x?

@c24t c24t merged commit a7308a0 into census-instrumentation:v0.6.x Jul 24, 2019
@c24t
Copy link
Copy Markdown
Member

c24t commented Jul 24, 2019

I disabled requiring signed commits for the release branches and restricted pushing to repo admins.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants