Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Add exception tracing to django middleware#885

Merged
lzchen merged 19 commits intocensus-instrumentation:masterfrom
tonybaloney:django_exception_tracing
Mar 31, 2021
Merged

Add exception tracing to django middleware#885
lzchen merged 19 commits intocensus-instrumentation:masterfrom
tonybaloney:django_exception_tracing

Conversation

@tonybaloney
Copy link
Copy Markdown
Contributor

Adds additional functionality to the Django middleware to capture exceptions and add the error message, type, and traceback to the trace span attributes.

Will attempt to use both Python 2 and 3 tracebacks

I'm new to this project, so please let me know if there's anything that needs changing

@tonybaloney tonybaloney requested review from a team, c24t, reyang and songy23 as code owners April 24, 2020 02:06
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tonybaloney
Copy link
Copy Markdown
Contributor Author

CLA signed

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@lzchen
Copy link
Copy Markdown
Contributor

lzchen commented Mar 4, 2021

Thanks for the addition!

Could you fix the build errors (I believe it's because we changed black_list to exclude_list #977) and add a CHANGELOG entry as well?

@tonybaloney
Copy link
Copy Markdown
Contributor Author

Thanks for the addition!

Could you fix the build errors (I believe it's because we changed black_list to exclude_list #977) and add a CHANGELOG entry as well?

@lzchen I can't see why the py37 build is failing? The others are fixed

@lzchen
Copy link
Copy Markdown
Contributor

lzchen commented Mar 5, 2021

@tonybaloney
The lint build is failing:
contrib/opencensus-ext-django/tests/test_django_middleware.py:351:80: E501 line too long (84 > 79 characters)

@lzchen
Copy link
Copy Markdown
Contributor

lzchen commented Mar 18, 2021

@tonybaloney
Are you still working on this? There are some changes that I would like to get released and if we could get this change in too that'd be great.

@tonybaloney
Copy link
Copy Markdown
Contributor Author

@lzchen nope, its finished if you're happy with it?

@lzchen
Copy link
Copy Markdown
Contributor

lzchen commented Mar 18, 2021

@tonybaloney
I've made some comments above that need to be addressed.

@tonybaloney
Copy link
Copy Markdown
Contributor Author

@lzchen requested amendments made

@lzchen lzchen closed this Mar 31, 2021
@lzchen lzchen reopened this Mar 31, 2021
@google-cla
Copy link
Copy Markdown

google-cla bot commented Mar 31, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Mar 31, 2021
@google-cla
Copy link
Copy Markdown

google-cla bot commented Mar 31, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Mar 31, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Mar 31, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@lzchen lzchen merged commit 8f348bb into census-instrumentation:master Mar 31, 2021
@tonybaloney tonybaloney deleted the django_exception_tracing branch March 31, 2021 23:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants